Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add script for single issuer and single holder ipex #126

Merged

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented Nov 2, 2023

Adding reference script for issuing a credential using a single issuer and a single holder. Includes updates to ipex().grant() from @kentbull.

Original post:

Referring to the discussion from discord today. Here is a script that performs credential issuance with IPEX grant + admit with a single issuer and a single holder.

This script stops at line L266 printing "No credentials yet..." because the holder never gets any credentials from its agent.

Do you have any pointers to what I am doing wrong here? I believe I am missing a crucial step in either the "issueCredential" or "admitCredential" function.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #126 (244aafa) into development (6282052) will increase coverage by 0.04%.
The diff coverage is 84.74%.

@@               Coverage Diff               @@
##           development     #126      +/-   ##
===============================================
+ Coverage        80.90%   80.94%   +0.04%     
===============================================
  Files               42       42              
  Lines             4117     4173      +56     
  Branches          1027     1028       +1     
===============================================
+ Hits              3331     3378      +47     
- Misses             754      763       +9     
  Partials            32       32              
Files Coverage Δ
src/keri/core/serder.ts 63.63% <100.00%> (+2.19%) ⬆️
src/keri/core/utils.ts 68.23% <97.36%> (+23.55%) ⬆️
src/keri/app/credentialing.ts 83.27% <50.00%> (-2.23%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@lenkan
Copy link
Collaborator Author

lenkan commented Nov 6, 2023

Thanks @pfeairheller for the updates and adding the /ipex/admit to KERIA. I have tried this again by porting the "submitAdmit" function to here.

However, KERIA now becomes unresponsive after posting the /ipex/admit message. After debugging I found that execution stops in the Admitter when calling "parseOne" on the "iss" embed: WebOfTrust/keria@f80d976#diff-a169faf61f8a8fdf3be4d9d2a164f646003d0f5203efb18f599f4b59393327efR527

parser.parseOne simply never returns. It gets stuck in the infinite loop here: https://github.com/WebOfTrust/keripy/blob/6ab521ec83f1bfd67882199fea4c5f45d91304c4/src/keri/core/parsing.py#L418

Do you have any idea as to what could cause the parser from getting stuck in an infinite loop.

I am a bit worried that these background tasks can make the API unresponsive. I thought maybe the Doers was a way to prevent that?

@lenkan lenkan marked this pull request as ready for review November 8, 2023 10:19
@rodolfomiranda rodolfomiranda merged commit 9f020f2 into WebOfTrust:development Nov 8, 2023
4 checks passed
@lenkan lenkan deleted the single-issuer-holder-ipex-script branch November 8, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants