fix: use response status_code instead of status

WebOfTrust · Nov 7, 2023 · bef9816 · bef9816
1 parent ba43e15
commit bef9816
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/src/signify/app/notifying.py b/src/signify/app/notifying.py
@@ -43,7 +43,7 @@ def markAsRead(self, nid):
 
         """
         res = self.client.put(f"/notifications/{nid}", json={})
-        return res.status == 202
+        return res.status_code == 202
 
     def delete(self, nid):
         """ Delete notification
@@ -56,6 +56,4 @@ def delete(self, nid):
 
         """
         res = self.client.delete(path=f"/notifications/{nid}")
-        # TODO: Figure out why res doesn't have status??
-        # return res.status == 202
-        return True
+        return res.status_code == 202
diff --git a/tests/app/test_notifying.py b/tests/app/test_notifying.py
@@ -41,13 +41,13 @@ def test_noticiation_mark_as_read():
     notes = Notifications(client=mock_client) # type: ignore
 
     from requests import Response
-    mock_response = mock({'status': 202}, spec=Response, strict=True)
+    mock_response = mock({'status_code': 202}, spec=Response, strict=True)
     expect(mock_client, times=1).put('/notifications/ABC123', json={}).thenReturn(mock_response)
 
     out = notes.markAsRead(nid="ABC123")
     assert out is True
 
-    mock_response = mock({'status': 404}, spec=Response, strict=True)
+    mock_response = mock({'status_code': 404}, spec=Response, strict=True)
     expect(mock_client, times=1).put('/notifications/DEF456', json={}).thenReturn(mock_response)
 
     out = notes.markAsRead(nid="DEF456")
@@ -65,17 +65,17 @@ def test_noticiation_delete():
     notes = Notifications(client=mock_client)  # type: ignore
 
     from requests import Response
-    mock_response = mock({'status': 202}, spec=Response, strict=True)
+    mock_response = mock({'status_code': 202}, spec=Response, strict=True)
     expect(mock_client, times=1).delete(path='/notifications/ABC123').thenReturn(mock_response)
 
     out = notes.delete(nid="ABC123")
     assert out is True
 
-    mock_response = mock({'status': 404}, spec=Response, strict=True)
+    mock_response = mock({'status_code': 404}, spec=Response, strict=True)
     expect(mock_client, times=1).delete(path='/notifications/DEF456').thenReturn(mock_response)
 
     out = notes.delete(nid="DEF456")
-    assert out is True
+    assert out is False
 
     verifyNoUnwantedInteractions()
     unstub()