Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use response status_code instead of status #95

Merged

Conversation

lenkan
Copy link
Contributor

@lenkan lenkan commented Nov 7, 2023

Check for status code was not correct in notifying.py. See docs: https://requests.readthedocs.io/en/latest/api/#requests.Response.status_code

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #95 (bef9816) into development (ba43e15) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           development      #95   +/-   ##
============================================
  Coverage        89.94%   89.94%           
============================================
  Files               16       16           
  Lines             1004     1004           
============================================
  Hits               903      903           
  Misses             101      101           
Files Coverage Δ
src/signify/app/notifying.py 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@pfeairheller pfeairheller merged commit c973aad into WebOfTrust:development Nov 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants