feat: 장부 내역 등록 API #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdoha
force-pushed
the
feat/create-ledger-api
branch
from
68caa1a to
1a4b890
Compare
rlarltj
approved these changes
Dec 21, 2023
rlarltj
approved these changes
Dec 21, 2023
Comment on lines
+10
to
+11
| if(fundType.equals(FundType.EXPENSE)) return -amount; | ||
| return amount; |
There was a problem hiding this comment.
dto, service 혹은 이 클래스에서 한 번 정도는 null check를 해주면 좋을 것 같아요.
There was a problem hiding this comment.
추후 @Valid 로 유효성 검증 할 예정이예요 null 체크 좋네요!
Comment on lines
+42
to
+45
| User user = userService.validateUser(userId); | ||
|
|
||
| // 2. 유저 소속 검증 | ||
| AgencyUser agencyUser = agencyService.validateAgencyUser(userId); |
There was a problem hiding this comment.
String userToken으로 입력을 받고 요거로 검증할 수 있을까요?? 👍
There was a problem hiding this comment.
우선은 userId 로 가져가려고 합니다..! 추후 유저 로직 구현되면 한번 더 고민하도록 하겠습니다.
Comment on lines
+25
to
+27
| return ledgerDocuments.stream() | ||
| .map(ledgerDocumentRepository::save) | ||
| .toList(); |
There was a problem hiding this comment.
다른 stream 연산을 사용하지 않으신다면, saveAll()은 어떠신가요?
ref
There was a problem hiding this comment.
레퍼런스 읽었습니다. 이 부분 제가 알기로는 save 와 saveAll 의 성능 차이는 없는 것으로 알고있습니다..!
Comment on lines
+50
to
+53
| // 4. 유저 권한 검증 | ||
| if(!agencyUser.getAgencyUserRole().equals(AgencyUserRole.STAFF)) { | ||
| throw new InvalidAccessException(ErrorCode.INVALID_LEDGER_ACCESS); | ||
| } |
There was a problem hiding this comment.
이 로직을 AgencyUser 엔티티 내부에서 처리하는 것은 어떨까요?
There was a problem hiding this comment.
'소속 내 운영진 권한일 경우에 장부 내역을 등록할 수 있다' 라는 비즈니스 로직에 대한 검증이여서 Ledger 내에 있는 것이 맞을 것 같아요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔배경
장부 내역 등록(수동 · 자동) 기능을 개발합니다.
📄 작업 사항
존재하지 않는 회원입니다.)소속에 가입 후 장부를 사용할 수 있습니다.)장부가 존재하지 않습니다.)유효하지 않은 접근입니다.)0원 ~ 999,999,999원까지 기입 가능합니다.)💻 테스트 화면
성공 응답 케이스
예외 검증