-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Implement incentives to all remaining components #2308
base: main
Are you sure you want to change the base?
✨ Implement incentives to all remaining components #2308
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@MartinGbz is attempting to deploy a commit to the Avara Team on Vercel. A member of the Team first needs to authorize it. |
…e it from the asset name
General Changes
This PR adds all the incentives (lm, merit, zksync ignite) on all remaining, ie:
It also move the "No APRs incentives tooltips" (like Spark airdrop or Superfest) from the asset name to the APRs.
So all incentives are now gather at the same place (aprs or not aprs), and it will also simplify the process of adding new "no aprs incentives" in the future.
It also fix 3 issues:
You can test all the cases on all Modals/Infos by mocking API returns, but here's a few screenshots of the preview:
Supply Info:
Switch Supply Modal:
Switch Debt Modal:
Supply Modal:
Borrow Modal:
SPK tooltip:
Developer Notes
Created a new
IncentivesBox
component that can be used everywhere in the app.So we only need to define any new incentive type in this component, and it will be display everywhere else.
Reviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.example
file as well as the pertinant.github/actions/*
files