Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support pausing and unpausing schedules #902

Merged
merged 14 commits into from
May 9, 2024
Merged

feat: Support pausing and unpausing schedules #902

merged 14 commits into from
May 9, 2024

Conversation

WillDaSilva
Copy link
Contributor

Closes #899

@coveralls
Copy link

coveralls commented May 2, 2024 •
edited
Loading

Coverage Status

coverage: 92.584% (-0.2%) from 92.772%
when pulling 56c23ec on WillDaSilva:master
into 4ca9251 on agronholm:master.

@WillDaSilva WillDaSilva marked this pull request as ready for review May 2, 2024 20:12
WillDaSilva
WillDaSilva commented May 2, 2024
View reviewed changes
src/apscheduler/_schedulers/async_.py Outdated Show resolved Hide resolved
src/apscheduler/_schedulers/sync.py Outdated Show resolved Hide resolved
agronholm
agronholm requested changes May 5, 2024
View reviewed changes
Copy link
Owner

@agronholm agronholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. I'll need some changes though.

src/apscheduler/datastores/memory.py Outdated Show resolved Hide resolved
src/apscheduler/datastores/sqlalchemy.py Outdated Show resolved Hide resolved
src/apscheduler/datastores/sqlalchemy.py Outdated Show resolved Hide resolved
src/apscheduler/_schedulers/async_.py Show resolved Hide resolved
src/apscheduler/_schedulers/async_.py Outdated Show resolved Hide resolved
src/apscheduler/_schedulers/async_.py Outdated Show resolved Hide resolved
src/apscheduler/_schedulers/async_.py Outdated Show resolved Hide resolved
src/apscheduler/datastores/mongodb.py Show resolved Hide resolved
agronholm
agronholm requested changes May 8, 2024
View reviewed changes
Copy link
Owner

@agronholm agronholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there now code-wise. I'll also require a changelog entry (docs/versionhistory.rst).

What about the documentation? I think this feature should be documented. Do you think you'd be up for that, or do you want me to do it?

src/apscheduler/_schedulers/async_.py Outdated Show resolved Hide resolved
src/apscheduler/_schedulers/async_.py Outdated Show resolved Hide resolved
@WillDaSilva
Copy link
Contributor Author

@agronholm Thanks for the review. I've addressed your comments related to the code, added an entry in the version history, and added a section about pausing and unpausing schedules to the docs. Let me know if you would like any changes to them, or if you would rather just update them yourself in a follow-up if my writing style in the docs isn't to your liking.

agronholm
agronholm approved these changes May 9, 2024
View reviewed changes
Copy link
Owner

@agronholm agronholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I couldn't have written the docs better myself!

@agronholm agronholm merged commit 9e9f905 into agronholm:master May 9, 2024
13 checks passed
@agronholm agronholm mentioned this pull request May 11, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterschutt peterschutt peterschutt left review comments

@agronholm agronholm agronholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support pausing and unpausing schedules
4 participants
@WillDaSilva @coveralls @agronholm @peterschutt