Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Sundry updates per review #1024

Merged
merged 2 commits into from
Dec 10, 2024
Merged

📝 Sundry updates per review #1024

merged 2 commits into from
Dec 10, 2024

Conversation

akrherz
Copy link
Owner

@akrherz akrherz commented Dec 10, 2024

No description provided.

Copy link

deepsource-io bot commented Dec 10, 2024

Here's the code health analysis summary for commits 17935f7..bde0e26. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 18 occurences introduced
View Check ↗
DeepSource Python LogoPython❌ Failure
❗ 8 occurences introduced
View Check ↗
DeepSource PHP LogoPHP✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.89041% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (17935f7) to head (bde0e26).

Files with missing lines Patch % Lines
pylib/iemweb/autoplot/scripts100/p137.py 84.61% 2 Missing ⚠️
pylib/iemweb/autoplot/scripts100/p165.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1024      +/-   ##
==========================================
+ Coverage   88.36%   88.40%   +0.03%     
==========================================
  Files         406      406              
  Lines       31426    31422       -4     
==========================================
+ Hits        27770    27778       +8     
+ Misses       3656     3644      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akrherz akrherz merged commit fcf115a into main Dec 10, 2024
10 of 12 checks passed
@akrherz akrherz deleted the 241210 branch December 10, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants