fix: use correct settings for server launch config #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonpaulos
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
This looks correct.
As for algosdk source maps, for that to work we'd have to include both the source maps and the actual source files, while making sure the source maps have the right path to the sources. Since vendoring the algosdk code is meant to be a short-term measure, I wasn't sure the benefit would be worth it. Let me know if you disagree.
|
@jasonpaulos Yeah I'm fine with that. Another alternative is to remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the settings for the server launch configuration.
I also noticed that source maps are referenced in the bundled algosdk source, however are not included.
This results in warnings being printed to console when launching the "Server" configuration.