-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: splitting compile into separate esm and cjs dists #111
Conversation
@PhearZero thanks for PR review! feel free to check how your comments were addressed, @tristanmenzel i tested it against generator ts and it works fine but i had to tweak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working example of what ./dist/package.json
should look like.
{
"main": "./cjs/index.js",
"module": "./esm/index.js",
"types": "./types/index.d.ts",
"name": "@algorandfoundation/algokit-utils",
"version": "0.1.0",
"private": false,
"description": "A set of core Algorand utilities written in TypeScript and released via npm that make it easier to build solutions on Algorand.",
"author": "Algorand Foundation",
"typesVersions": {
"*": {
".": [
"types/index.d.ts"
],
"types/app": [
"types/types/app.d.ts"
],
"types/app-client": [
"types/types/app-client.d.ts"
],
"types/app-spec": [
"types/types/app-spec.d.ts"
],
"types/transaction": [
"types/types/transaction.d.ts"
]
}
},
"license": "MIT",
"engines": {
"node": ">=16.0"
},
"files": [
"**/*"
],
"exports": {
".": {
"import": "./esm/index.js",
"require": "./cjs/index.js",
"types": "./types/index.d.ts"
},
"./testing": {
"import": "./esm/testing/index.js",
"require": "./cjs/testing/index.js",
"types": "./types/testing/index.d.ts"
},
"./index.d.ts": "./types/index.d.ts",
"./package.json": "./package.json"
},
"overrides": {
"semver": "7.5.2"
},
"dependencies": {
"algosdk": "^2.3.0",
"buffer": "^6.0.3"
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🕺🏻
thanks @PhearZero will await for @tristanmenzel to take a peek and will merge this early next week 👍 |
LGTM @aorumbayev! |
Proposed changes
instanceof
onjs-algorand-sdk
side. An implementation of a fix proposed by @PhearZero