Publishing components upgrade #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callumknights
force-pushed
the
publishing-components-upgrade
branch
8 times, most recently
from
ee82769 to
68a4616
Compare
brucebolt
reviewed
Jul 17, 2024
callumknights
force-pushed
the
publishing-components-upgrade
branch
from
68a4616 to
b78a37d
Compare
|
I've also had a separate conversation with @MartinJJones @brucebolt, I'm gonna merge this with the commit upgrading Publishing-components left in, and close the dependabot PR. |
brucebolt
reviewed
Jul 17, 2024
brucebolt
approved these changes
Jul 17, 2024
mike21573
changed the title
This replaces Uglifier, as Terser supports ES6
This change is part of the process for upgrading apps to a new version of govuk_publishing_components that uses GOV.UK frontend V5.1 This is one of the steps detailed in the [Upgrading to GOV.UK Frontend v5 document](https://docs.google.com/document/d/1uwip7pzQwM7t5ghn9_8KrsWXLePSRUltFPZ5fYw6Ab8/edit). The purpose of this is to prevent browsers that don't support ES6 attempting to load ES6 Javascript from our components. We know browser that don't support ES6 as grade X browsers, and these browsers also don't support the `type = "module"` attribute in script tags. So we use this to prevent such code being loaded by ES6 Browsers. The 'all_components' require as been removed to avoid grade X browsers calling ES6 javascript
mike21573
force-pushed
the
publishing-components-upgrade
branch
from
b78a37d to
c154b45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/E0hw9QCZ/1241-upgrade-govukpublishingcomponents-for-transition
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.