feat: added documentation for premium notifications #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Features
UpdateBug FixesContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
ivelin
requested changes
May 26, 2021
There was a problem hiding this comment.
@vickywane make this PR available for preview on your main fork with all CI checks passing.
Added a few inline comments for language styling.
* feat: added documentation for premium notifications * update: expanded docs and added relevant images * update: linked premium-services to quickstart
|
Something is not adding up. When I look at your fork, there is no CI
running. No actions triggered.
https://github.com/vickywane/ambianic-docs/actions
…On Wed, May 26, 2021 at 6:10 PM Nwani Victory ***@***.***> wrote:
@ivelin <https://github.com/ivelin> This
<https://github.com/vickywane/ambianic-docs> is my fork of this pull
request available for review.
All CI checks passed in the pull request here
<vickywane#1> before it was merged.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARBUFLFMMLBF3JS2A5CKJLTPV5XXANCNFSM45OPJL2A>
.
|
vickywane
force-pushed
the
premium-services
branch
from
d72c329 to
3ef7697
Compare
ivelin
requested changes
May 31, 2021
There was a problem hiding this comment.
@vickywane The text looks good. See comments on organizing sections and menus.
vickywane
force-pushed
the
premium-services
branch
from
59fa174 to
94eb4ab
Compare
ivelin
requested changes
Jun 1, 2021
vickywane
force-pushed
the
premium-services
branch
from
464b954 to
76b2e9c
Compare
ivelin
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the documentation of the new premium notifications within the Ambianic PWA UI here into the Ambianic Docs
The new changes are introduced in the
premium-services.mdfile which is linked to the Quickstart Guide in the Ambianic Premium Services section.