Added ansible support for LLDP TLVs(port-vlan-id, vlan-name, link-aggregation, maximum-frame-size)

[thenmozhi-gopal]

SUMMARY

Added ansible support for LLDP TLVs(port-vlan-id, vlan-name, link-aggregation, maximum-frame-size)
Related PR:
ansible-network/resource_module_models#264

GitHub Issues

List the GitHub issues impacted by this PR. If no Github issues are affected, please indicate this with "N/A".

GitHub Issue #
N/A

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

Sonic_lldp_interfaces

OUTPUT

ADDITIONAL INFORMATION

Checklist:

• I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
• I have verified that new and existing unit tests pass locally with my changes
• I have not allowed coverage numbers to degenerate
• I have maintained at least 90% code coverage
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
• I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Regression test report:
Initial regression-report.pdf
Regression-report -latest - 12 Dec 2024
regression-2024-12-12-17-26-02.html.pdf
Regrssion-report-Jan 6 2025
regression_result_6_jan.pdf
Regression report - Jan10 2025
regression-2025-01-10-22-03-31.html.pdf

[kerry-meyer]

In order to proceed with the code review and merging of these changes, please fix the sanity and UT errors flagged for the current change set posted in this PR.

[awhaley-dell]

The content of this looks good from my first pass. I have only a minor formatting suggestion for the fragment file and a question about a unit test validation function.

[kerry-meyer]

This change set looks good for the most part, but I am posting several questions and requests for changes.

I would also like to check the UT coverage results after the additional changes are pushed.

[kerry-meyer]

I'm adding a couple more comments/questions on the unit test files.

[stalabi1]

Diff and check mode aren't implemented in for this module. Perhaps you can implement it in this PR. You can refer to the implementation of diff and check mode in the lldp_global module or any of the other several modules where it is implemented.

dellemc.enterprise_sonic/plugins/module_utils/network/sonic/config/lldp_global/lldp_global.py

Line 149 in 1ded095

if self._module.check_mode:

[thenmozhi-gopal]

Diff and check mode aren't implemented in for this module. Perhaps you can implement it in this PR. You can refer to the implementation of diff and check mode in the lldp_global module or any of the other several modules where it is implemented.

dellemc.enterprise_sonic/plugins/module_utils/network/sonic/config/lldp_global/lldp_global.py

Line 149 in 1ded095

if self._module.check_mode:

diff and check mode implementation would be done as separate story (https://jira.cec.lab.emc.com/browse/SNC01F-55)

[kerry-meyer]

Although most of the previous change requests have been addressed and are now resolved, I am posting some additional change requests (and a question, which I think is answered by comments on the UT "test..." file).

[kerry-meyer]

I have checked and "Resolved" all of my previously posted "Issues".

The current functional code and corresponding test results look good, although I am posting two "Issues" related to comments and documentation.

One of my new "Issues" is a revised form of a previous "Issue", changed due to the modified action in the affected allowed_vlan list conversion function. The other is just for removal of unneeded quotes in the "modules" file "Examples" section.

[kerry-meyer]

All currently posted changes and corresponding test results look good.

Thank you for providing the Ansible support for the LLDP interface TLVs.

[awhaley-dell]

All my previous concerns were addressed. Looks good to me. Thanks for taking our advice into consideration.