Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ansible lint errors in some module files #498

Merged

Conversation

aida-shumburo
Copy link
Collaborator

@aida-shumburo aida-shumburo commented Jan 3, 2025

SUMMARY

There are a set of “Ansible Lint” failures currently flagged against the enterprise_sonic Ansible resource module collection. This PR is to fix roughly half of them.

ISSUE TYPE
  • Docs Pull Request
OUTPUT

output when running ansible-lint on plugins/modules:
Remaining ansible_lint errors in modules folder.txt

The listed errors are going to be addressed in a seperate PR

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document
How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@aida-shumburo aida-shumburo marked this pull request as ready for review January 3, 2025 19:05
@stalabi1 stalabi1 added the documentation Improvements or additions to documentation label Jan 6, 2025
@stalabi1 stalabi1 added this to the v3.1.0 milestone Jan 6, 2025
@jeff-yin jeff-yin merged commit 46691e4 into ansible-collections:main Jan 7, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants