Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing ansible-lint failures within the plugins/module directory part 2 #500

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

awhaley-dell
Copy link
Collaborator

@awhaley-dell awhaley-dell commented Jan 10, 2025

SUMMARY

This PR contains fixes for ansible-lint errors and style corrections for files within the modules directory.
These include whitespace fixes, indentation corrections, standardizing example state section naming scheme, and adding newlines between variables.

ISSUE TYPE
  • Docs Pull Request
OUTPUT
dellemc.enterprise_sonic/plugins/modules> ansible-lint --offline 
Passed: 0 failure(s), 0 warning(s) on 135 files. Last profile that met the validation criteria was 'production'.
Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document
How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran "ansible-lint" on the plugins/modules folder to verify there are no more correctable issues.

@awhaley-dell awhaley-dell added the documentation Improvements or additions to documentation label Jan 10, 2025
@awhaley-dell awhaley-dell added this to the v3.1.0 milestone Jan 10, 2025
@awhaley-dell awhaley-dell self-assigned this Jan 10, 2025
@awhaley-dell awhaley-dell changed the title Snc 40967 reducing ansible lint errors 6 hour sprint Fixing ansible-lint failures within the plugins/module directory part 2 Jan 10, 2025
@awhaley-dell awhaley-dell marked this pull request as ready for review January 10, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant