Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GROOVY-7407] Compilation not thread safe if Grape / Ivy is used in Groovy scripts #2142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

basil
Copy link

@basil basil commented Jan 14, 2025

See GROOVY-7407 (comment). Implements the same high-level solution used in the workaround tested and delivered to Jenkins users in jenkinsci/pipeline-groovy-lib-plugin#148. Not tested directly, but the high-level solution was tested indirectly via JENKINS-72050 (comment) and jenkinsci/pipeline-groovy-lib-plugin#148 by two separate people.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.8290%. Comparing base (de5ff81) to head (be537f3).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2142        +/-   ##
==================================================
+ Coverage     68.8220%   68.8290%   +0.0071%     
- Complexity      29434      29435         +1     
==================================================
  Files            1420       1420                
  Lines          113147     113147                
  Branches        19544      19544                
==================================================
+ Hits            77870      77878         +8     
+ Misses          28738      28732         -6     
+ Partials         6539       6537         -2     

see 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants