Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ZEPPELIN-5972] Support Flink 1.17 #4677

Merged
merged 5 commits into from
Oct 22, 2023
Merged

[ZEPPELIN-5972] Support Flink 1.17 #4677

merged 5 commits into from
Oct 22, 2023

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Oct 16, 2023

What is this PR for?

This PR aims to support Flink 1.17, it's basically based on #4583

PS: I have an offline discussion with @zjffdu to take over this PR.

What type of PR is it?

Feature

Todos

  • - Task

What is the Jira issue?

TODO

How should this be tested?

Pass GA.

Screenshots (if appropriate)

Questions:

  • Does the license files need to update? No.
  • Is there breaking changes for older versions? No.
  • Does this needs documentation? No.

@pan3793 pan3793 changed the title WIP Support Flink 1.17 [ZEPPELIN-5972] Support Flink 1.17 Oct 16, 2023
@pan3793
Copy link
Member Author

pan3793 commented Oct 17, 2023

@zjffdu would mind taking a look?

Also, would you like to discuss removing the legacy Flink version support from Zeppelin, seems there are no sufficient developer resources at the Zeppelin community to maintain so many Flink versions, and according to https://flink.apache.org/downloads/, only Flink 1.16 and 1.17 are actively maintained by the Flink community, plus the upcoming Flink 1.18, do you think it's good to keep the latest 3 versions?

@Reamer
Copy link
Contributor

Reamer commented Oct 17, 2023

I would also like to see less flink versions supported.

@huage1994 huage1994 requested a review from zjffdu October 17, 2023 14:32
@jhchee
Copy link

jhchee commented Oct 22, 2023

@pan3793 Thanks for your contribution, is there any plan to merge into master?

@pan3793
Copy link
Member Author

pan3793 commented Oct 22, 2023

@jhchee thanks for noticing this PR, I think it's ready to go, and you are also welcome to review and test this patch, it requires a committer to merge (I don't have such power)

@huage1994 huage1994 merged commit efadcd6 into apache:master Oct 22, 2023
32 checks passed
akoira pushed a commit to akoira/zeppelin that referenced this pull request Feb 1, 2024
@pan3793 @zjffdu
[ZEPPELIN-5972] Support Flink 1.17 (apache#4677)
8e1eea3 
* Support Flink 1.17

* Bump Flink 1.17.1

* Fix package name

* fix java 11 compile

* empty

---------

Co-authored-by: Jeff Zhang <zjffdu@apache.org>
@pan3793 pan3793 deleted the flink-1.17 branch March 23, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huage1994 huage1994 huage1994 approved these changes

@zjffdu zjffdu zjffdu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pan3793 @Reamer @jhchee @zjffdu @huage1994