add dev warning if provider class is used as target

badasintended · Nov 24, 2023 · 73de725 · 73de725
1 parent bba4c1a
commit 73de725
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/src/main/java/mcp/mobius/waila/registry/Registrar.java b/src/main/java/mcp/mobius/waila/registry/Registrar.java
@@ -183,6 +183,7 @@ public <T> void addIcon(IBlockComponentProvider provider, Class<T> clazz, int pr
         if (Waila.CLIENT_SIDE) {
             assertLock();
             assertPriority(priority);
+            warnTargetClass(provider, clazz);
             blockIcon.add(clazz, provider, priority);
         }
     }
@@ -192,6 +193,7 @@ public <T> void addComponent(IBlockComponentProvider provider, TooltipPosition p
         if (Waila.CLIENT_SIDE) {
             assertLock();
             assertPriority(priority);
+            warnTargetClass(provider, clazz);
             blockComponent.get(position).add(clazz, provider, priority);
         }
     }
@@ -201,6 +203,7 @@ public <T> void addComponent(IBlockComponentProvider provider, TooltipPosition p
     public <T, BE extends BlockEntity> void addBlockData(IDataProvider<BE> provider, Class<T> clazz, int priority) {
         assertLock();
         assertPriority(priority);
+        warnTargetClass(provider, clazz);
         blockData.add(clazz, (IDataProvider<BlockEntity>) provider, priority);
     }
 
@@ -214,6 +217,7 @@ public <T> void addOverride(IEntityComponentProvider provider, Class<T> clazz, i
         if (Waila.CLIENT_SIDE) {
             assertLock();
             assertPriority(priority);
+            warnTargetClass(provider, clazz);
             entityOverride.add(clazz, provider, priority);
         }
     }
@@ -223,6 +227,7 @@ public <T> void addIcon(IEntityComponentProvider provider, Class<T> clazz, int p
         if (Waila.CLIENT_SIDE) {
             assertLock();
             assertPriority(priority);
+            warnTargetClass(provider, clazz);
             entityIcon.add(clazz, provider, priority);
         }
     }
@@ -232,6 +237,7 @@ public <T> void addComponent(IEntityComponentProvider provider, TooltipPosition
         if (Waila.CLIENT_SIDE) {
             assertLock();
             assertPriority(priority);
+            warnTargetClass(provider, clazz);
             entityComponent.get(position).add(clazz, provider, priority);
         }
     }
@@ -241,6 +247,7 @@ public <T> void addComponent(IEntityComponentProvider provider, TooltipPosition
     public <T, E extends Entity> void addEntityData(IDataProvider<E> provider, Class<T> clazz, int priority) {
         assertLock();
         assertPriority(priority);
+        warnTargetClass(provider, clazz);
         entityData.add(clazz, (IDataProvider<Entity>) provider, priority);
     }
 
@@ -314,4 +321,10 @@ private void assertPriority(int priority) {
             "Priority must be equals or more than 0");
     }
 
+    private void warnTargetClass(Object object, Class<?> clazz) {
+        if (Waila.DEV && clazz.isInstance(object)) {
+            LOG.warn("The target class {} is the same as the provider class, this is probably an error", clazz.getSimpleName());
+        }
+    }
+
 }