Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BRS-351: Add Null/Missing Data Export #371

Merged
merged 4 commits into from
Aug 30, 2024
Merged

BRS-351: Add Null/Missing Data Export #371

merged 4 commits into from
Aug 30, 2024

Conversation

davidclaveau
Copy link
Collaborator

Ticket:

BRS-351

Ticket URL:

BRS-351

Description:

  • Add functionality for export Missing Data
    • This will find all variances with -100% data and print out the past three years of data (if possible) and current year's input
  • Also, reorder the Variance Report so it prints out in this order: Froncountry Camping, Frontcountry Cabins, Group Camping, Backcountry Camping, Backcountry Cabins, Boating, Day Use (this matches Missing export order as well)
  • Linting fixes to applicable files

@davidclaveau
add missing data export tab functionality
1ad8ae1 
Signed-off-by: David <daveclaveau@gmail.com>
@davidclaveau
revert local dynamo url commit
2d082a4 
Signed-off-by: David <daveclaveau@gmail.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 28, 2024
View reviewed changes
arSam/template.yaml Dismissed Show dismissed Hide dismissed
arSam/template.yaml Dismissed Show dismissed Hide dismissed
marklise
marklise approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@marklise marklise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 /w nits

arSam/handlers/export-missing/GET/index.js Outdated Show resolved Hide resolved
arSam/handlers/export-missing/GET/index.js Outdated Show resolved Hide resolved
arSam/handlers/export-missing/GET/index.js Outdated Show resolved Hide resolved
arSam/handlers/export-missing/__tests__/export-missing.tests.js Outdated Show resolved Hide resolved
arSam/handlers/export-missing/__tests__/export-missing.tests.js Outdated Show resolved Hide resolved
arSam/handlers/export-missing/__tests__/export-missing.tests.js Outdated Show resolved Hide resolved
arSam/handlers/export-missing/__tests__/export-missing.tests.js Outdated Show resolved Hide resolved
arSam/handlers/export-missing/GET/index.js Outdated Show resolved Hide resolved
arSam/layers/baseLayer/baseLayer.js Outdated Show resolved Hide resolved
@davidclaveau
resolving PR change suggestions
fc3baf9 
Signed-off-by: David <daveclaveau@gmail.com>
@davidclaveau
fix test
031fbc0 
Signed-off-by: David <daveclaveau@gmail.com>
@davidclaveau davidclaveau merged commit 7e9f7fc into bcgov:main Aug 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marklise marklise marklise approved these changes

@cameronpettit cameronpettit Awaiting requested review from cameronpettit cameronpettit is a code owner

@danieltruong danieltruong Awaiting requested review from danieltruong danieltruong is a code owner

@meredithom meredithom Awaiting requested review from meredithom meredithom is a code owner

@Christopher-walsh22 Christopher-walsh22 Awaiting requested review from Christopher-walsh22 Christopher-walsh22 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidclaveau @marklise