Decompose map startup, move map into context, and refactor draw tools #3761
Conversation
There was a problem hiding this comment.
-
Whats here Tool doesn't work
-
Form Activity shape does work
-
Recordset Shapes no longer appearing on the Map
-
Drawn polygon nearly invisible (low opacity)
-
increasing the padding of the
current draw modebox topadding: 2pt 5pt;would be a nice improvement- The Draw mode boxes positioning is awkward for screen real estate. if possible, something more akin to this so it takes over less space
- Labels could be more user friendly. This will definitely be one of the first things the SOs note about the changes
-
Draw tools not duplicating!
I've also been getting this error (and in similar areas). I don't think its specific to your branch, but highlighting in case
Lots of console logs left, but assuming those will get removed after finalization
No comment or issues with code/styling stands out
|
I did not get errors for What's Here, however the functionality does not work as intended. On toggling the recordset layer, I see this : Neat breaking down of the map components! |
plasticviking
force-pushed
the
draw-tools-refactor-revisited
branch
from
976438c to
d70aa20
Compare
plasticviking
force-pushed
the
draw-tools-refactor-revisited
branch
from
d70aa20 to
13ab197
Compare
There was a problem hiding this comment.
Tested in FF And Chrome
Draw tools:
- Activity
- Line tool not working, sometimes makes polygon
- Whats Here
- Works much better than before ✅
- Custom Layer
- Line tool works but doesn't show on map
- Disabled
- Can draw a Polygon, but it disappears immediately
- Map Caching ✅
Minors:
- Draw Mode box could use some slight padding to not go edge to edge
Hard to fully judge the supplied code knowing its broken down legacy code, so skipped being uptight about it.
No new console errors during the testing :) Old ones pointed out at last review no longer occurring. In fact, there are less console errors than before!
Specifically this one is gone during the test:
| break; | ||
| } | ||
|
|
||
| //drawInstance.current.changeMode('whats_here_box_mode'); |
|
Overview
This PR includes the following proposed change(s):
Type of change
if your change is a breaking change, please add
breaking changelabel to this PRHow Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Screenshots
Please add any relevant UI screenshots if applicable.
Checklist: