Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding airbyte containers #35

Merged
merged 6 commits into from
Dec 1, 2023
Merged

adding airbyte containers #35

merged 6 commits into from
Dec 1, 2023

Conversation

abimichel
Copy link
Contributor

@abimichel abimichel commented Nov 14, 2023 •
edited by github-actions bot
Loading

Description

Adding containers for https://github.com/bcgov/nr-airbyte

Fixes # (issue)

  • Bug fix (non-breaking change which fixes an issue)
  • [ x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested in OpenShift a1b9b0-dev namespace

Checklist

  • [ x ] I have read the CONTRIBUTING doc
  • [ x ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ x ] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Any new images should be viewable with our repo packages. :)

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 14, 2023
View reviewed changes
airbyte/airbyte-web/Dockerfile Outdated
@@ -0,0 +1,9 @@
FROM nginx:alpine

Check failure

Code scanning / Trivy

Image user should not be 'root'

Artifact: airbyte/airbyte-web/Dockerfile Type: dockerfile Vulnerability DS002 Severity: HIGH Message: Specify at least 1 USER command in Dockerfile with non-root user as argument Link: [DS002](https://avd.aquasec.com/misconfig/ds002)
airbyte/airbyte-web/Dockerfile Outdated
@@ -0,0 +1,9 @@
FROM nginx:alpine

Check notice

Code scanning / Trivy

No HEALTHCHECK defined

Artifact: airbyte/airbyte-web/Dockerfile Type: dockerfile Vulnerability DS026 Severity: LOW Message: Add HEALTHCHECK instruction in your Dockerfile Link: [DS026](https://avd.aquasec.com/misconfig/ds026)
airbyte/airbyte-worker/Dockerfile Dismissed Show dismissed Hide dismissed
airbyte/airbyte-worker/Dockerfile Dismissed Show dismissed Hide dismissed
@mishraomp
Copy link
Contributor

@abimichel the images are not getting build, please add them to the pipeline, also could you please address the trivy alerts.

@abimichel abimichel marked this pull request as draft November 15, 2023 02:30
@abimichel abimichel self-assigned this Nov 15, 2023
@DerekRoberts DerekRoberts reopened this Nov 16, 2023
@abimichel abimichel marked this pull request as ready for review November 30, 2023 17:58
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 30, 2023
View reviewed changes
airbyte/airbyte-web/Dockerfile Dismissed Show dismissed Hide dismissed
airbyte/airbyte-web/Dockerfile Dismissed Show dismissed Hide dismissed
@abimichel abimichel enabled auto-merge (squash) December 1, 2023 21:04
mishraomp
mishraomp approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@mishraomp mishraomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abimichel abimichel merged commit 8f2ed9d into main Dec 1, 2023
6 checks passed
@abimichel abimichel deleted the airbyte branch December 1, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishraomp mishraomp mishraomp approved these changes

@DerekRoberts DerekRoberts Awaiting requested review from DerekRoberts DerekRoberts is a code owner

Assignees

@abimichel abimichel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abimichel @mishraomp @DerekRoberts