Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update react monorepo to v19 (major) #10

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 10, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
react (source) 18.3.1 -> 19.0.0 age adoption passing confidence
react-dom (source) 18.3.1 -> 19.0.0 age adoption passing confidence

Release Notes

facebook/react (react)

v19.0.0

Compare Source

facebook/react (react-dom)

v19.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - "before 4am on tuesday" in timezone America/Vancouver, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link
Contributor Author

renovate bot commented Dec 10, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @docsearch/react@3.8.2
npm warn Found: react@19.0.0
npm warn node_modules/react
npm warn   react@"19.0.0" from the root project
npm warn   25 more (@docusaurus/core, @docusaurus/mdx-loader, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peerOptional react@">= 16.8.0 < 19.0.0" from @docsearch/react@3.8.2
npm warn node_modules/@docsearch/react
npm warn   @docsearch/react@"^3.8.1" from @docusaurus/theme-search-algolia@3.7.0
npm warn   node_modules/@docusaurus/theme-search-algolia
npm warn
npm warn Conflicting peer dependency: react@18.3.1
npm warn node_modules/react
npm warn   peerOptional react@">= 16.8.0 < 19.0.0" from @docsearch/react@3.8.2
npm warn   node_modules/@docsearch/react
npm warn     @docsearch/react@"^3.8.1" from @docusaurus/theme-search-algolia@3.7.0
npm warn     node_modules/@docusaurus/theme-search-algolia
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @docsearch/react@3.8.2
npm warn Found: react-dom@19.0.0
npm warn node_modules/react-dom
npm warn   react-dom@"19.0.0" from the root project
npm warn   18 more (@docusaurus/core, @docusaurus/mdx-loader, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peerOptional react-dom@">= 16.8.0 < 19.0.0" from @docsearch/react@3.8.2
npm warn node_modules/@docsearch/react
npm warn   @docsearch/react@"^3.8.1" from @docusaurus/theme-search-algolia@3.7.0
npm warn   node_modules/@docusaurus/theme-search-algolia
npm warn
npm warn Conflicting peer dependency: react-dom@18.3.1
npm warn node_modules/react-dom
npm warn   peerOptional react-dom@">= 16.8.0 < 19.0.0" from @docsearch/react@3.8.2
npm warn   node_modules/@docsearch/react
npm warn     @docsearch/react@"^3.8.1" from @docusaurus/theme-search-algolia@3.7.0
npm warn     node_modules/@docusaurus/theme-search-algolia
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: docusaurus-json-schema-plugin@1.12.2
npm error Found: react@19.0.0
npm error node_modules/react
npm error   react@"19.0.0" from the root project
npm error   peer react@"^18.0.0 || ^19.0.0" from @docusaurus/core@3.7.0
npm error   node_modules/@docusaurus/core
npm error     @docusaurus/core@"3.7.0" from the root project
npm error     @docusaurus/core@"3.7.0" from @docusaurus/plugin-content-blog@3.7.0
npm error     node_modules/@docusaurus/plugin-content-blog
npm error       @docusaurus/plugin-content-blog@"3.7.0" from @docusaurus/preset-classic@3.7.0
npm error       node_modules/@docusaurus/preset-classic
npm error         @docusaurus/preset-classic@"3.7.0" from the root project
npm error       1 more (@docusaurus/theme-classic)
npm error     14 more (@docusaurus/plugin-content-docs, ...)
npm error   24 more (@docusaurus/mdx-loader, ...)
npm error
npm error Could not resolve dependency:
npm error peer react@">=17 <= 18" from docusaurus-json-schema-plugin@1.12.2
npm error node_modules/docusaurus-json-schema-plugin
npm error   docusaurus-json-schema-plugin@"1.12.2" from the root project
npm error
npm error Conflicting peer dependency: react@18.3.1
npm error node_modules/react
npm error   peer react@">=17 <= 18" from docusaurus-json-schema-plugin@1.12.2
npm error   node_modules/docusaurus-json-schema-plugin
npm error     docusaurus-json-schema-plugin@"1.12.2" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /tmp/renovate/cache/others/npm/_logs/2025-01-11T01_13_57_081Z-eresolve-report.txt
npm error A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2025-01-11T01_13_57_081Z-debug-0.log

@renovate renovate bot requested a review from jujaga as a code owner December 10, 2024 08:09
jujaga
jujaga previously requested changes Dec 10, 2024
Copy link
Member

@jujaga jujaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporarily blocking as it looks like Docusaurus hasn't expanded to React 19 in its dependencies yet.

@renovate renovate bot force-pushed the renovate/major-react-monorepo branch from 4eb1e3c to 4621ac2 Compare December 10, 2024 17:27
@jujaga jujaga marked this pull request as draft December 10, 2024 17:29
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch from 4621ac2 to 258276e Compare December 11, 2024 01:26
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch 4 times, most recently from 0762618 to 353ede1 Compare December 13, 2024 20:38
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch 4 times, most recently from a3522e1 to fbff804 Compare December 18, 2024 18:04
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch 5 times, most recently from c6f1aef to 1051b5a Compare December 24, 2024 22:49
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch from 1051b5a to 7ce5ca3 Compare December 27, 2024 20:38
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch 3 times, most recently from bdf6735 to e154add Compare January 3, 2025 01:20
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch 2 times, most recently from b691459 to 8e7b0cc Compare January 4, 2025 01:42
@jujaga jujaga marked this pull request as ready for review January 8, 2025 00:47
@jujaga
Copy link
Member

jujaga commented Jan 8, 2025

Should be unblocked by #12 and can proceed as React 19 is supported by Docusaurus 3.7 onwards.

@jujaga jujaga dismissed their stale review January 8, 2025 00:48

Removing block

@renovate renovate bot force-pushed the renovate/major-react-monorepo branch from 8e7b0cc to 3ba5d32 Compare January 8, 2025 00:49
@jujaga jujaga force-pushed the renovate/major-react-monorepo branch from 2047518 to 3ba5d32 Compare January 8, 2025 01:00
@jujaga
Copy link
Member

jujaga commented Jan 8, 2025

docusaurus-json-schema-plugin does not work with React 19 yet. Blocking until this is resolved in jy95/docusaurus-json-schema-plugin/pull/523

@renovate renovate bot force-pushed the renovate/major-react-monorepo branch from 3ba5d32 to 4d053d2 Compare January 8, 2025 01:03
@jujaga jujaga marked this pull request as draft January 8, 2025 01:04
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch from 4d053d2 to 5b08fc1 Compare January 8, 2025 01:32
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch from 5b08fc1 to 4745d9d Compare January 11, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant