Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHO CCIP 1.5.1 Upgrade Eth<>Arb #557

Open
wants to merge 69 commits into
base: main
Choose a base branch
from

Conversation

DhairyaSethi
Copy link
Contributor

@DhairyaSethi DhairyaSethi commented Jan 2, 2025

Goal

Upgrade Existing ETH & ARB token pools to CCIP 1.5.1 by deploying new token pools, migrating liquidity to them & completely deprecating existing token pools.
This AIP aims to achieve this by:

  1. Accepting ownerships of:
    • new token pool
    • admin role for GHO token of CCIP TokenAdminRegistry
    • existing proxy pool (even though they'll be deprecated)
  2. Migrating Liquidity between old & new token pools:
    • ETH (LockRelease type): move tokens to new pool & update currentBridged
    • ARB (BurnMint type): Mint tokens on new pool, transfer to old pool, and burn tokens from old pool - this is done to offboard old pool as a facilitator and enable the new pool to offRamp existing bridged supply. (note that a facilitator can only burn (offRamp) amount which it has itself minted)
  3. Setup new token pool with rate limits of 300k capacity & 60 rate.
  4. Update Stewards with the new token pools.

Notes:

  • the proxy pattern used is vanilla OZ v5.1 transparent.
  • sanity check no leftover tokens in existing eth token pool.
  • we can upgrade the existing ETH pool to reset bridgedAmount as well, but it's not needed since we reset bridgeLimit.
  • 1.5.1 TokenPools: CCIP 1.5.1 aave/ccip#20
  • For 2.b: Since the existing burn mint type token pool does not have an explicit method to burn supply, a new permissioned method directBurn is introduced in DirectBurn on RemotePool aave/ccip#21

parth-15 and others added 30 commits December 5, 2023 23:04
* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>
* fix: Make new impl constant

* fix: Fix AIP text
@MichaelMorami
Copy link

✅ The upgrade was fully reviewed and approved by Certora.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants