Adds grip edge/vertex generation functionality from FHIR files. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwalsh
requested changes
Nov 3, 2023
| # uuid regex | ||
| pattern = r'[a-zA-Z]+/[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}' | ||
| names = [] | ||
| print("SIMPLIFIED ORIG: ", simplified) |
There was a problem hiding this comment.
We should remove debugging statement.
| for elems in names: | ||
| simplified.pop(elems) | ||
|
|
||
| print("SIMPLIFIED: ", simplified) |
| @@ -88,10 +88,10 @@ def create_fhir_definitions_lookup(iceberg_path: str = "~/.iceberg"): | |||
| connection = sqlite3.connect(path) | |||
|
|
|||
| with connection: | |||
| connection.execute(f'DROP table IF EXISTS element_bindings') | |||
| connection.execute(f'CREATE TABLE if not exists element_bindings (id PRIMARY KEY, entity Text)') | |||
| connection.execute('DROP table IF EXISTS element_bindings') | |||
… into grip-etl-addon
|
This got implemented in https://github.com/bmeg/jsonschemagraph instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vertex generation test: python -m pytest tests/integration/simplified/test_simplify_task_grip.py -s
iceberg data simplify tests/fixtures/simplify/synthea grip_data --schema_path https://raw.githubusercontent.com/bmeg/iceberg/feature/updated-schemas/schemas/graph/graph-fhir.json --dialect GRIP --project_id synthea-testworks
See #25 for description of use case. (BW)