-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PHPUnit Version #69
base: master
Are you sure you want to change the base?
Update PHPUnit Version #69
Conversation
<directory suffix=".php">./src</directory> | ||
</whitelist> | ||
</filter> | ||
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" bootstrap="vendor/autoload.php" colors="true" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EXPLAIN the great change here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PHPUnit nagged about the xml not being as expected and I ran PHPUnit with the flag to update it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll need to check for this.
Maybe there's a smaller config.
"slim/slim": "^4.0" | ||
}, | ||
"require-dev": { | ||
"phpunit/phpunit": "^7.0" | ||
"phpunit/phpunit": "^9.6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HOW does it change anything?
Does this SUPPORT slim/slim@^4.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fundamentally does it change anything? NO, that's why I introduced it as a pedantic PR.
Functionally it's the same.
What it does do is it gives the library a fresh lick of paint, as otherwise the repo is functionally complete.
I have been using this library as a teaching demonstration of a good framework agnostic lib because of its support for PSR-15. I ultimately began tinkering and thus this PR came to fruition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it might change something...
I need to check for PHPUnit 9.6 min PHP version, for example.
So the whole project remains installable with Slim 4.0.0.
The other option is to see Slim 4.x versions usage and accommodate properly (so your change could get merged).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose ^9.6
because that is what Slim 4.x uses: https://github.com/slimphp/Slim/blob/4.x/composer.json#L68 ultimately this is a dev dependancy however and can be different as it's only installed when working on this library directly and not when required by another.
From its install documentation, PHPUnit 9.6 requires at least PHP 7.3.
This might be considered a pedantic PR, however I have updated the version of PHPUnit used by this library to be in parity with that used by version four of the Slim framework.