Resolve "Add processBefore parameter to kraken.futures.Trade.{cancel_order,edit_order,create_order,create_batch_order}"
#192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_order,create_order,create_batch_order}
btschwertfeger
added
enhancement
…uturestradecancel_orderedit_ordercreate_ordercreate_batch_order
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #192 +/- ##
==========================================
- Coverage 89.46% 89.45% -0.01%
==========================================
Files 21 21
Lines 1879 1888 +9
==========================================
+ Hits 1681 1689 +8
- Misses 198 199 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
btschwertfeger
deleted the
191-add-processbefore-parameter-to-krakenfuturestradecancel_orderedit_ordercreate_ordercreate_batch_order
branch
btschwertfeger
added a commit
that referenced
this pull request
Mar 12, 2024
…ncel_order`,`edit_order`,`create_order`,`create_batch_order`}" (#192)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the new parameters.
This PR must wait before merge until #189 is merged, since the still broken futures tests will fail and block the merge.