Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add unmerged normalize endpoint (#263) #266

Merged
merged 9 commits into from
Apr 25, 2022
Merged

feat: add unmerged normalize endpoint (#263) #266

merged 9 commits into from
Apr 25, 2022

Conversation

jsstevenson
Copy link
Member

Close #263

  • Add endpoint that provides normalized concept group data but doesn't merge to a single ValueObject Descriptor

This is needed for DGIdb and the same feature is required for genes, so we should settle on the shape of the output here to keep them consistent

@jsstevenson jsstevenson requested a review from korikuzma April 22, 2022 15:48
korikuzma
korikuzma requested changes Apr 25, 2022
View reviewed changes
therapy/schemas.py Outdated Show resolved Hide resolved
therapy/main.py Show resolved Hide resolved
therapy/query.py Outdated Show resolved Hide resolved
@jsstevenson jsstevenson requested a review from korikuzma April 25, 2022 16:45
@jsstevenson jsstevenson merged commit ab70af8 into staging Apr 25, 2022
@jsstevenson jsstevenson deleted the issue-263 branch April 25, 2022 18:14
@jsstevenson jsstevenson mentioned this pull request Apr 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korikuzma korikuzma korikuzma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsstevenson @korikuzma