Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose prometheus metrics #35

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

kadaan
Copy link

@kadaan kadaan commented Mar 26, 2020

what

  • Exposes metrics from the prometheus-to-cloudwatch service via the standard prometheus scrape endpoint.
  • Creates the following metrics:
    • Total Publishes
    • Total Publish Errors
    • Publish Duration
    • Total Metrics
  • New port chosen that doesn't collide with existing prometheus exporters.

image

why

  • There is no current ability to monitor the prometheus-to-cloudwatch service
  • This exposes total and error metrics that can allow prometheus alerts to be created that will notify based on failure rate or hung process.
  • Monitoring is needed to be able to rely on this service in production environments

references

@aknysh
Copy link
Member

aknysh commented Apr 22, 2020

@kadaan thanks for the PR.
Looks like you are adding a server and prometheus to be able to get metrics from this app itself, correct?
Can you please add more description to the PR in the form:

## what
* Describe high-level what changed as a result of these commits (i.e. what do these changes mean)
* Use bullet points to be concise and to the point

## why
* Provide the justifications for the changes (e.g. business case)
* Describe why these changes were made (e.g. why do these commits fix the problem)
* Use bullet points to be concise and to the point

## references
* Link to any supporting GitHub issues or helpful documentation to add some context (e.g. stackoverflow)
* Use `closes #123`, if this PR closes a GitHub issue `#123`

@kadaan
Copy link
Author

kadaan commented Apr 22, 2020

@aknysh Updated

@osterman osterman requested a review from aknysh July 6, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants