Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature adds for controller scan #21

Open
wants to merge 1 commit into
base: v2.0.0
Choose a base branch
from

Conversation

jhenson29
Copy link
Collaborator

@jhenson29 jhenson29 commented Jun 9, 2018

Sample of suggested updates for Controller scan

Description, Motivation, and Context

Adds ability to remove and query tags in the subscription group.
Adds ability to set scan for read only
Check elapsed time for scan and modifies wait time accordingly so update rate is close to set scan rate.
Added scan min overhead percent to keep a minimum amount of wait time relative to the task time

How Has This Been Tested?

Minimal testing against a PLC

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This is a work in progress, and I want some feedback (If yes, please mark it in the title -> e.g. [WIP] Some awesome PR title)

Related Issue

@coveralls
Copy link

Pull Request Test Coverage Report for Build 73

  • 17 of 22 (77.27%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.0%) to 51.133%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/controller/index.js 15 20 75.0%
Totals Coverage Status
Change from base Build 70: 1.0%
Covered Lines: 431
Relevant Lines: 810

💛 - Coveralls

@cmseaton42 cmseaton42 self-requested a review June 10, 2018 11:46
@cmseaton42 cmseaton42 changed the base branch from master to v2.0.0 February 23, 2019 20:04
@cmseaton42 cmseaton42 changed the title [WIP] feature adds for controller scan Feature adds for controller scan Feb 23, 2019
@cmseaton42 cmseaton42 added the enhancement New feature or request label Feb 23, 2019
@cmseaton42 cmseaton42 self-assigned this Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants