Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAS - Adds commentary and double strokes lines #1154

Merged
merged 1 commit into from
Nov 22, 2023
Merged

OAS - Adds commentary and double strokes lines #1154

merged 1 commit into from
Nov 22, 2023

Conversation

anvega
Copy link
Contributor

@anvega anvega commented Nov 22, 2023

Adds Ann Wallace's commentary and double stroke to other comments

@anvega
OAS - Adds commentary and double strokes lines
131c508 
Adds Ann Wallace's commentary and double stroke to other comments

Signed-off-by: Andres Vega <av@monkey.org>
@netlify Netlify
Copy link

netlify bot commented Nov 22, 2023 •
edited
Loading

✅ Deploy Preview for tag-security canceled.

Name Link
🔨 Latest commit 131c508
🔍 Latest deploy log https://app.netlify.com/sites/tag-security/deploys/655d74515932c2000886681e

JustinCappos
JustinCappos approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@JustinCappos JustinCappos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shift from two columns to one is a little jarring, but overall I think it fits fine. Ann's perspective is a valuable addition.

@JustinCappos JustinCappos merged commit ef28a68 into main Nov 22, 2023
10 checks passed
@anvega anvega deleted the anvega-oas-commentary branch June 6, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinCappos JustinCappos JustinCappos approved these changes

@mnm678 mnm678 Awaiting requested review from mnm678

@lumjjb lumjjb Awaiting requested review from lumjjb

@mlieberman85 mlieberman85 Awaiting requested review from mlieberman85

@ultrasaurus ultrasaurus Awaiting requested review from ultrasaurus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anvega @JustinCappos