Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing with master #1173

Closed
wants to merge 60 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
dbb64c6
Created project folder and self-assesment file
Igor8mr Nov 16, 2023
e76789d
Added overview and completed Self-assessment use
Igor8mr Nov 25, 2023
588ae43
add actors data
MatthewZGong Nov 25, 2023
52f05dc
add background
MatthewZGong Nov 26, 2023
01f3efb
added goals and non goals
MatthewZGong Nov 26, 2023
30b4cc0
added actions
MatthewZGong Nov 26, 2023
0461979
Secure Development practices
MatthewZGong Nov 26, 2023
e9eab85
Fixed issues and started writting the Appendix
Igor8mr Nov 26, 2023
88bbca1
Added Security functions and features (critical)
devyani-14 Nov 27, 2023
3e63fac
Added Security functions and features (security relevant)
devyani-14 Nov 27, 2023
726ec9d
Continued working on Appendix and fixed issues
Igor8mr Nov 27, 2023
b836671
Fixed indentation and other markdown linting issues
Igor8mr Nov 27, 2023
5f2df31
Security issue resolution and other changes
Igor8mr Nov 27, 2023
958f6e8
Finished working on Security issue resolution
Igor8mr Nov 28, 2023
bbd641c
Added project compliance, cii best practices and case studies
Kushal-kothari Nov 28, 2023
f8d5274
Update self-assessment.md
Kushal-kothari Nov 28, 2023
6bc589d
Added more goals, non-goals and actions
Igor8mr Nov 28, 2023
1ad6311
Merge branch 'main' of https://github.com/Igor8mr/tag-security
Igor8mr Nov 28, 2023
773b5c6
Added SBOM and other changes
Igor8mr Nov 28, 2023
7950d5f
Added lightweight threat modelling
Igor8mr Nov 28, 2023
5b9575a
Fixed formatting issues
Igor8mr Nov 28, 2023
04a34f9
More fixes
Igor8mr Nov 28, 2023
38df388
More fixes
Igor8mr Nov 28, 2023
516f56e
Added a conclusion to the threat modelling.
Igor8mr Nov 29, 2023
ee86480
Fixed overview
Igor8mr Nov 29, 2023
ed4db7f
More fixes
Igor8mr Nov 29, 2023
6ae5f18
Update for suggestions #1 and #2
devyani-14 Nov 30, 2023
3589a3a
Update for suggestion #3
devyani-14 Dec 1, 2023
22fc804
Updates
Igor8mr Dec 3, 2023
b521ee3
Merge branch 'main' of https://github.com/Igor8mr/tag-security
Igor8mr Dec 3, 2023
6ed4941
Fixed more of the comments from Slack
Igor8mr Dec 3, 2023
4077865
Added more hyperlinks
Igor8mr Dec 3, 2023
2159c99
Added more pictures and hyperlinks
Igor8mr Dec 4, 2023
08c3f47
Fixed more comments from slack
Igor8mr Dec 4, 2023
3654dd3
Updated TOC and Security Issue resolution
Igor8mr Dec 4, 2023
41b220a
More Fixes
Igor8mr Dec 4, 2023
3aca607
edits from feedback for goals
MatthewZGong Dec 4, 2023
a1dc74a
Added a new hyperlink
Igor8mr Dec 4, 2023
0f59b80
Merge branch 'main' of https://github.com/Igor8mr/tag-security
Igor8mr Dec 4, 2023
aa029ed
Small Fixes
Igor8mr Dec 4, 2023
7a6272c
added links to sdk
MatthewZGong Dec 5, 2023
0bb5baf
added links for prs
MatthewZGong Dec 5, 2023
ee0c55e
sdks links
MatthewZGong Dec 5, 2023
3e666be
Action Items
MatthewZGong Dec 5, 2023
ba84de6
Fixed some formatting issues
Igor8mr Dec 5, 2023
92b522b
incorporated the newly drafted "Action Items" section
Kushal-kothari Dec 5, 2023
4f7a362
Fixed some issues
Igor8mr Dec 5, 2023
5ef0a23
More updates and added a communicaitons file
Igor8mr Dec 5, 2023
15a5be1
Update self-assessment.md for Action items - setup of synk for SDKs
devyani-14 Dec 5, 2023
80b91de
Added new communications and hyperlinks.
Igor8mr Dec 5, 2023
6f56548
Merge branch 'main' of https://github.com/Igor8mr/tag-security
Igor8mr Dec 5, 2023
c0b33af
Fixed Issues
Igor8mr Dec 5, 2023
a8ef37b
Fixed some of the newer comments.
Igor8mr Dec 5, 2023
53b280f
Fixed a lot of grammar issues
Igor8mr Dec 5, 2023
9041992
Fixed more issues
Igor8mr Dec 5, 2023
0568531
Improved the formatting of the action items
Igor8mr Dec 5, 2023
aa05197
Updated table of contents
Igor8mr Dec 5, 2023
6430125
Fixed issue
Igor8mr Dec 5, 2023
7257f09
Syncing with master (#2)
Igor8mr Dec 6, 2023
1ba9666
Syncing with master (#3)
Igor8mr Dec 6, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 49 additions & 37 deletions PUBLICATIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,20 @@
This document lists all the publications and resources that TAG Security has
produced.

## Cloud Native Security Controls Catalog

Mapping of Cloud Native Security Whitepaper and Software Supply Chain Best
Practices Paper to NIST SP800-53r5

- [Markdown](https://github.com/cncf/tag-security/blob/main/cloud-native-controls/phase-one-announcement.md)
- [Spreadsheet](https://docs.google.com/spreadsheets/d/1GUohOTlLw9FKUQ3O23X7ypvJLXN-B3veJGe6YE6JYfU/edit?usp=sharing)

## Cloud Native Security Lexicon

Standardization of terminologies specific to Cloud Native Security

- [Markdown](https://github.com/cncf/tag-security/blob/main/security-lexicon/cloud-native-security-lexicon.md)

## Cloud Native Security Whitepaper

The Cloud Native Security Whitepaper (CNSWP) is a TAG Security effort to ensure
Expand All @@ -23,6 +37,41 @@ Translations
- [Chinese](https://github.com/cncf/tag-security/blob/main/security-whitepaper/v1/cloud-native-security-whitepaper-simplified-chinese.md)
(v1)

## Open and Secure - A Manual for Practicing Threat Modeling to Assess and Fortify Open Source Security

A comprehensive guide dedicated to assessing and understanding the security of open source software projects. The book is the culmination of five years of TAG Secure Assessments, practical insights, and collaborative effort from experts in the field. Our goal? To empower you with the knowledge and skills to enhance the security of the cloud native ecosystem, the projects, and their use in your organization’s platforms.

- [PDF](https://github.com/cncf/tag-security/blob/main/assessments/Open_and_Secure.pdf)

## Policy

### Formal Verification for Policy Configurations

- [Markdown](https://github.com/cncf/tag-security/blob/main/policy/overview-policy-formal-verification.md)

### Handling build-time dependency vulnerabilities

- [Markdown](https://github.com/cncf/tag-security/blob/main/policy/overview-policy-build-time-dependency-vulns.md)

## Secure Defaults: Cloud Native 8

- [Markdown](https://github.com/cncf/tag-security/blob/main/security-whitepaper/secure-defaults-cloud-native-8.md)

## Security Assessments

TAG Security has conducted security assessments of several CNCF projects. These
assessments are available to the public.

- [Buildpacks](https://github.com/cncf/tag-security/tree/main/assessments/projects/buildpacks)
- [Cloud
Custodian](https://github.com/cncf/tag-security/tree/main/assessments/projects/custodian)
- [Harbor](https://github.com/cncf/tag-security/tree/main/assessments/projects/harbor)
- [In-toto](https://github.com/cncf/tag-security/tree/main/assessments/projects/in-toto)
- [Keycloak](https://github.com/cncf/tag-security/tree/main/assessments/projects/keycloak)
- [Kyverno](https://github.com/cncf/tag-security/tree/main/assessments/projects/kyverno)
- [OPA](https://github.com/cncf/tag-security/tree/main/assessments/projects/opa)
- [Spiffe-Spire](https://github.com/cncf/tag-security/tree/main/assessments/projects/spiffe-spire)

## Supply Chain Security

### Software Supply Chain Best Practices
Expand Down Expand Up @@ -54,11 +103,7 @@ them

- [Markdown](https://github.com/cncf/tag-security/tree/main/supply-chain-security/compromises)

## Cloud Native Security Lexicon

Standardization of terminologies specific to Cloud Native Security

- [Markdown](https://github.com/cncf/tag-security/blob/main/security-lexicon/cloud-native-security-lexicon.md)

## Use Cases & Personas

Expand All @@ -67,39 +112,6 @@ of cloud native technology

- [Markdown](https://github.com/cncf/tag-security/blob/main/usecase-personas/README.md)

## Policy

### Formal Verification for Policy Configurations

- [Markdown](https://github.com/cncf/tag-security/blob/main/policy/overview-policy-formal-verification.md)

### Handling build-time dependency vulnerabilities

- [Markdown](https://github.com/cncf/tag-security/blob/main/policy/overview-policy-build-time-dependency-vulns.md)

## Secure Defaults: Cloud Native 8

- [Markdown](https://github.com/cncf/tag-security/blob/main/security-whitepaper/secure-defaults-cloud-native-8.md)

## Cloud Native Security Controls Catalog

Mapping of Cloud Native Security Whitepaper and Software Supply Chain Best
Practices Paper to NIST SP800-53r5

- [Markdown](https://github.com/cncf/tag-security/blob/main/cloud-native-controls/phase-one-announcement.md)
- [Spreadsheet](https://docs.google.com/spreadsheets/d/1GUohOTlLw9FKUQ3O23X7ypvJLXN-B3veJGe6YE6JYfU/edit?usp=sharing)

## Security Assessments

TAG Security has conducted security assessments of several CNCF projects. These
assessments are available to the public.

- [Buildpacks](https://github.com/cncf/tag-security/tree/main/assessments/projects/buildpacks)
- [Cloud
Custodian](https://github.com/cncf/tag-security/tree/main/assessments/projects/custodian)
- [Harbor](https://github.com/cncf/tag-security/tree/main/assessments/projects/harbor)
- [In-toto](https://github.com/cncf/tag-security/tree/main/assessments/projects/in-toto)
- [Keycloak](https://github.com/cncf/tag-security/tree/main/assessments/projects/keycloak)
- [Kyverno](https://github.com/cncf/tag-security/tree/main/assessments/projects/kyverno)
- [OPA](https://github.com/cncf/tag-security/tree/main/assessments/projects/opa)
- [Spiffe-Spire](https://github.com/cncf/tag-security/tree/main/assessments/projects/spiffe-spire)
15 changes: 1 addition & 14 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -151,19 +151,6 @@ seen [here](governance/related-groups/)

### On-going projects

#### Policy team

Policy is an essential component of a secure system.

[Bi-weekly meetings](https://docs.google.com/document/d/1ihFfEfgViKlUMbY2NKxaJzBkgHh-Phk5hqKTzK-NEEs/edit?usp=sharing)
at 3:00 PM PT focus on policy concerns and initiatives.

Co-leads

- TBD

Co-chair representative: @achetal01

#### Security reviews

[Security reviews](./assessments) are a collaborative process for the benefit of
Expand All @@ -173,7 +160,7 @@ the project and its risk profile.
Facilitator: Justin Cappos ([@JustinCappos](https://github.com/JustinCappos)),
New York University

Facilitator: Andres Vega ([@anvega](https://github.com/anvega)), ControlPlane
Facilitator: Andrés Vega ([@anvega](https://github.com/anvega))

Co-chair representatives: @sublimino @PushkarJ

Expand Down
Binary file added assessments/Open_and_Secure.pdf
Binary file not shown.
Binary file removed assessments/Open_and_Secure_Early_Access.pdf
Binary file not shown.
213 changes: 213 additions & 0 deletions assessments/projects/cloud-events/CE-maintainers-communications.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,213 @@
# Communications with CloudEvents Maintainers

## Slack Communications

* **Security Pals Involved:**
* Igor Rodrigues (Igor Rodrigues)
* **CloudEvents Team Members Involved:**
* Doug Davis (dug)

### Slack Report

#### Igor Rodrigues (Nov 29th at 4:29:13 PM)

* [Message
Link](https://cloud-native.slack.com/archives/C9DB5ABAA/p1701293353624819)

Hello all, I'm a student at NYU involved in the SecurityPal effort from TAG
Security. Our group is conducting a security assessment on CloudEvents, which we
will later submit to the [TAG Security Assessments
Repository](https://github.com/cncf/tag-security/tree/main). We have completed
an [initial
evaluation](https://github.com/Igor8mr/tag-security/blob/main/assessments/projects/cloud-events/self-assessment.md)
of the project and would appreciate your feedback to validate the information we
included. We also want to know if there are additional aspects we should include
in the assessment to correctly represent your project, along with more details
for sections like [security issue
resolution](https://github.com/Igor8mr/tag-security/blob/main/assessments/projects/cloud-events/self-assessment.md#security-issue-resolution)
and [secure development
practices](https://github.com/Igor8mr/tag-security/blob/main/assessments/projects/cloud-events/self-assessment.md#secure-development-practices).
Please, feel free to share your thoughts here on Slack, on GitHub, or on a call.
Thank you!

#### Dug (Nov 29th at 8:02:04 PM)

* [Message
Link](https://cloud-native.slack.com/archives/C9DB5ABAA/p1701306124114029?thread_ts=1701293353.624819&cid=C9DB5ABAA)

Hi @Igor Rodrigues - will take a look. Just curious though, what made you decide
to analyze CloudEvents?

#### Igor Rodrigues (Nov 29th at 8:36:26 PM)

* [Message
Link](https://cloud-native.slack.com/archives/C9DB5ABAA/p1701308186825319?thread_ts=1701293353.624819&cid=C9DB5ABAA)

Hi @dug, thank you. The assessment is one of our assignments for a class we are
taking with Professor Justin Cappos. Each group was assigned to a CNCF project,
and ours was CloudEvents. The project is interesting, so we are trying to do a
bit more than expected. I hope the assessment helps in the future.

#### Dug (Nov 30th at 10:24:13 AM)

* [Message
Link](https://cloud-native.slack.com/archives/C9DB5ABAA/p1701357853677559?thread_ts=1701293353.624819&cid=C9DB5ABAA)

@Igor Rodrigues thanks. Just a few comments from my quick scan:

* Where do you see ANTRL being used? I'm surprised you didn't include markdown
in the list despite it not being a "programming language", being a "spec"
markdown is kind of our "language" :slightly_smiling_face:
* `CloudEvents was developed to address the lack of uniformity in event data
format...` be a bit careful here. While CE does provide a "structured" format,
that's just there are times when people want the event data and context
attributes in one doc. In general though CE is NOT trying to define "yet
another common event format (one format to rule them all)". In particular,
many people use/prefer "binary" format because it just augments their existing
events. And even with "structured", the stuff that does into the `data`
attribute is wide open - and should be defined by the business. I just don't
want people to think we're making the same mistake as other folks who tried to
force one format for all events. Rather CE is about standardizing "where to
find common metadata about the event w/o having to parse/understand the event
specific format".
* Nit: in "Protocol Binding" section it mentions `structured-mode` but hasn't
defined that term yet. You may want to define binary vs structured CEs in the
doc before this section.
* Not sure what the "trust boundary" is meant to represent in the diagram since
"trust" is kind of orthogonal to the roles.
* Goals: may want to tweak some of those based on my comments above. Plus, some
of those aren't really goals for CE since CE doesn't control them. For
example, "generate events before consumers are listening" - a good idea, but
CE doesn't really talk about those in the spec itself. CE is just about the
format and how they might appear on the transports. With a few exceptions, it
doesn't get into the protocols themselves or event
management/subscriptions.....
* CE is under review for Graduation status right now... hopefully will be
approved very soon
* CE doesn't really describe any encryption mechanism or deal with integrity -
the text you wrote kind of implies CE addresses it. Perhaps say something like
it's an implementation detail/choice??
* Ecosystem - might be good to link to the [cloudevents.io](cloudevents.io) site
which includes a list of adopters.
* The "Security issue resolution" section reads like an SDK specific section -
perhaps "SDK" should appear in the title to make it clear that the following
sections apply to the SDK repos and not the spec repo?
* There's also a new security mailing list people should use to report security
concerns: https://lists.cncf.io/g/cncf-cloudevents-security/topics
* There is no "CloudEvents Steering Committee" that's mentioned in the Threat
Modelling section (typo in Modelling)
* It might be good to mention that (I think) all of the security issues found by
Trail of Bits have been addressed

#### Igor Rodrigues (Nov 30th at 11:58:51 AM)

* [Message
Link](https://cloud-native.slack.com/archives/C9DB5ABAA/p1701363531073659?thread_ts=1701293353.624819&cid=C9DB5ABAA)

Hi @dug, Thank you for all the comments! For ANTLR, GitHub marked it as 14.1% of
the [CloudEvents spec](https://github.com/cloudevents/spec), so that's why I
added it to the assessment, but I may remove it if it's not very relevant. I'll
also definitely add Markdown, thanks for noticing that. We'll review the doc,
update it with your comments and tell you about the changes. Thank you again!

#### Igor Rodrigues (Dec 4th at 11:15:26 AM)

* [Message
Link](https://cloud-native.slack.com/archives/C9DB5ABAA/p1701706526314599?thread_ts=1701293353.624819&cid=C9DB5ABAA)

Hi @dug, we fixed the comments you provided on the [security
assessment](https://github.com/Igor8mr/tag-security/blob/main/assessments/projects/cloud-events/self-assessment.md),
along with the comments from the meeting. Here are the [new
changes](https://github.com/cncf/tag-security/commit/e75e0e0a908ffa462c7923fad6e6e201b5feaef0#diff-086780f8339d58b8abcf32f9cf930f8b11ebf1889ee3e36c4eeaede7dc21a7b7)
since then. Please, let me know if there are more parts we could improve. Also,
I wanted to CloudEvents have a public SBOM that we could link, and if you think
there are more aspects we could add to the specification side of the [Security
Issue
resolution](https://github.com/Igor8mr/tag-security/blob/main/assessments/projects/cloud-events/self-assessment.md#cloudevents-specification).
Thank you for all the help!

#### Dug (Dec 4th at 11:36:23 AM)

* [Message
Link](https://cloud-native.slack.com/archives/C9DB5ABAA/p1701707783421699?thread_ts=1701293353.624819&cid=C9DB5ABAA)

The closest thing we have to a SBOM is:
https://github.com/cloudevents/spec#cloudevents-documents Thanks for the update.
Will look it over in a bit.

#### Igor Rodrigues (Dec 4th at 11:44:52 AM)

* [Message
Link](https://cloud-native.slack.com/archives/C9DB5ABAA/p1701708292972649?thread_ts=1701293353.624819&cid=C9DB5ABAA)

Great, thanks!

#### Dug (Dec 4th at 12:08:22 PM)

* [Message
Link](https://cloud-native.slack.com/archives/C9DB5ABAA/p1701709702994029?thread_ts=1701293353.624819&cid=C9DB5ABAA)

I put just a few minor tweaks as comments on the commit.

#### Igor Rodrigues (Dec 4th at 12:28:53 PM)

* [Message
Link](https://cloud-native.slack.com/archives/C9DB5ABAA/p1701710933601919?thread_ts=1701293353.624819&cid=C9DB5ABAA)

Thanks, I'll fix those soon

#### Igor Rodrigues (Dec 5th at 8:05:09 AM)

* [Message
Link](https://cloud-native.slack.com/archives/C9DB5ABAA/p1701781509377939?thread_ts=1701293353.624819&cid=C9DB5ABAA)

Hi @dug, I forgot to ask this before, but are there any action items you are
currently working on or plan to work on that would solve the concerns mentioned
in the doc or other security concerns? I think it would be good to include those
in the assessment. I remember you mentioned implementing bots to check the SDKs,
do you have a pull request, issue, or any other link to the implementation of
the bots idea? Also, we are willing to help implement one of those solutions to
the concerns if you have some specific things in mind.

#### Dug (Dec 5th at 11:57:30 AM)

* [Message
Link](https://cloud-native.slack.com/archives/C9DB5ABAA/p1701795450643219?thread_ts=1701293353.624819&cid=C9DB5ABAA)

@Igor Rodrigues just this one: https://github.com/cloudevents/spec/issues/1235

#### Dug (Dec 5th at 11:58:19 AM)

* [Message
Link](https://cloud-native.slack.com/archives/C9DB5ABAA/p1701795499076589?thread_ts=1701293353.624819&cid=C9DB5ABAA)

If someone knows how to setup the bots and wants to submit a PR to add them...
that would be great! Or even just a list of instructions for an admin to follow
(if it's more than just a PR) that would be great too.

#### Igor Rodrigues (Dec 5th at 12:12:57 PM)

* [Message
Link](https://cloud-native.slack.com/archives/C9DB5ABAA/p1701796377013619?thread_ts=1701293353.624819&cid=C9DB5ABAA)

Great, thanks! We are taking a look here

## CloudEvents Team Meeting

* **Security Pals Involved:**
* Igor Rodrigues
* **CloudEvents Team Members Involved:**
* Doug Davis
* Tommy
* Erik
* David B
* Jon
* Calum
* Jem
* Clemens

### Team Meeting Report

The team joined the CloudEvents public team meeting on November 30th, 2023,
which was [recorded on
YouTube](https://www.youtube.com/watch?v=2OZPTQOqFEw&t=191s).
Loading
Loading