Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkerd Project Security Self-Assessment - Security Pals #1181

Merged
merged 5 commits into from
Jan 18, 2024

Conversation

amanda-gonzalez
Copy link
Contributor

Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for tag-security canceled.

Name Link
🔨 Latest commit ab8ac5e
🔍 Latest deploy log https://app.netlify.com/sites/tag-security/deploys/65a96b24d22db00008c86d62

@eddie-knight
Copy link
Collaborator

Hi there! I'm just getting started looking at your pull request, and I noticed the DCO check is failing.

You can look at the checks section of the PR (I believe it should always be below the last comment) and look for a red X highlighting the failed check. In this case, you can click Details for more information about how to get that check passing.
Screenshot 2023-12-08 at 8 35 18 AM

@eddie-knight
Copy link
Collaborator

I noticed that you included an SBOM along with the self assessment. There are two reasons that jump to the front of my mind for why this isn't needed...

SBOMs should be associated with releases, as the bill of materials is only accurate and useful if it is created at build time and associated to a particular point in the code history.
If you need to link to an SBOM for some reason in the self-assessment, you can just provide a link out to the latest build artifacts that contain an SBOM.
We still have plenty more to review, but as a starter— could you please remove the SBOM from this PR?

@Shugo0016 Shugo0016 force-pushed the main branch 2 times, most recently from 21db14c to 1bd7b7a Compare December 9, 2023 03:13
Copy link
Contributor

@ragashreeshekar ragashreeshekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @amanda-gonzalez and team, appreciate the efforts.
I have completed first pass of review and comments on sections that need your attention. Please feel free to reach out here or on slack for any questions and clarifications.

Along with addressing the comments, kindly update the PR branch with the latest content in the repo as this branch is out-of-date with the base branch.

assessments/projects/linkerd/self-assessment.md Outdated Show resolved Hide resolved
assessments/projects/linkerd/self-assessment.md Outdated Show resolved Hide resolved
assessments/projects/linkerd/self-assessment.md Outdated Show resolved Hide resolved
assessments/projects/linkerd/self-assessment.md Outdated Show resolved Hide resolved
assessments/projects/linkerd/self-assessment.md Outdated Show resolved Hide resolved
assessments/projects/linkerd/self-assessment.md Outdated Show resolved Hide resolved
@amanda-gonzalez amanda-gonzalez changed the title Linkerd Security Self-Assessment Linkerd Project Security Self-Assessment - Security Pals Dec 11, 2023
Copy link
Contributor Author

@amanda-gonzalez amanda-gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes made after ragashreeshekar's review:

  • fixed formatting
  • provided relevant links
  • clarified vulnerabilities section
  • removed appendix
  • reworked CII section

@amanda-gonzalez
Copy link
Contributor Author

Thank you @eddie-knight and @ragashreeshekar. We have resolved all reviews/requests. Most recently updated are:

  • table of contents
  • self-assessment use statement

Signed-off-by: amanda <109336105+amanda-gonzalez@users.noreply.github.com>
Co-Authored-By: Kaya Erol <kue202@nyu.edu>
Co-Authored-By: Thaison Le <tnl2012@nyu.edu>
Co-Authored-By: Dwireph Kamleshkumar Parmar <dp3757@nyu.edu>
Signed-off-by: Kaya Erol <kue202@nyu.edu>
Signed-off-by: amanda <109336105+amanda-gonzalez@users.noreply.github.com>
Co-Authored-By: Kaya Erol <kue202@nyu.edu>
Co-Authored-By: Thaison Le <tnl2012@nyu.edu>
Co-Authored-By: Dwireph Kamleshkumar Parmar <dp3757@nyu.edu>
Signed-off-by: Kaya Erol <kue202@nyu.edu>
Copy link
Collaborator

@JustinCappos JustinCappos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice assessment. Some really minor writing issues (kubernetes vs Kubernetes, minor grammar, etc.) but it's clear and ready to merge.

@JustinCappos JustinCappos merged commit 3f71bb8 into cncf:main Jan 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants