-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linkerd Project Security Self-Assessment - Security Pals #1181
Conversation
✅ Deploy Preview for tag-security canceled.
|
I noticed that you included an SBOM along with the self assessment. There are two reasons that jump to the front of my mind for why this isn't needed... SBOMs should be associated with releases, as the bill of materials is only accurate and useful if it is created at build time and associated to a particular point in the code history. |
21db14c
to
1bd7b7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @amanda-gonzalez and team, appreciate the efforts.
I have completed first pass of review and comments on sections that need your attention. Please feel free to reach out here or on slack for any questions and clarifications.
Along with addressing the comments, kindly update the PR branch with the latest content in the repo as this branch is out-of-date with the base branch.
14feb82
to
2580548
Compare
4a19f9d
to
2580548
Compare
be732b2
to
6394aff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes made after ragashreeshekar's review:
- fixed formatting
- provided relevant links
- clarified vulnerabilities section
- removed appendix
- reworked CII section
Thank you @eddie-knight and @ragashreeshekar. We have resolved all reviews/requests. Most recently updated are:
|
Signed-off-by: amanda <109336105+amanda-gonzalez@users.noreply.github.com> Co-Authored-By: Kaya Erol <kue202@nyu.edu> Co-Authored-By: Thaison Le <tnl2012@nyu.edu> Co-Authored-By: Dwireph Kamleshkumar Parmar <dp3757@nyu.edu> Signed-off-by: Kaya Erol <kue202@nyu.edu>
Signed-off-by: amanda <109336105+amanda-gonzalez@users.noreply.github.com> Co-Authored-By: Kaya Erol <kue202@nyu.edu> Co-Authored-By: Thaison Le <tnl2012@nyu.edu> Co-Authored-By: Dwireph Kamleshkumar Parmar <dp3757@nyu.edu> Signed-off-by: Kaya Erol <kue202@nyu.edu>
Signed-off-by: Ragashree M C <ragashreeshekar@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nice assessment. Some really minor writing issues (kubernetes vs Kubernetes, minor grammar, etc.) but it's clear and ready to merge.
Contributors: