Skip to content

Commit

Permalink
Merge pull request #85 from coinbase/wilson/update-ms
Browse files Browse the repository at this point in the history
Magic Spend -> MagicSpend
  • Loading branch information
wilsoncusack authored Oct 22, 2024
2 parents 52d3f16 + d28b18c commit 710a742
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions docs/pages/checklist.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ If your app does any offchain signature validation (such as Sign-In With Ethereu
do any signature validation, ensure your app is [ERC-6492](https://eips.ethereum.org/EIPS/eip-6492) compliant.
See [our guide](/guides/signature-verification).

### Magic Spend Compatible
Magic Spend enables users to get "just in time" transaction funding from their Coinbase account.
### MagicSpend Compatible
MagicSpend enables users to get "just in time" transaction funding from their Coinbase account.
This is currently supported for ETH only on Base.
To give users the best experience, apps should make use of the `auxiliaryFunds` capability
and ensure they are not blocking actions based solely on onchain balance checks. See [our guide](/guides/magic-spend).
Expand Down
4 changes: 2 additions & 2 deletions docs/pages/guides/magic-spend.mdx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Magic Spend
# MagicSpend

With Magic Spend, Smart Wallet users can use their Coinbase balances onchain. This means users can easily start using onchain apps without needing to onramp funds into their wallet.
With MagicSpend, Smart Wallet users can use their Coinbase balances onchain. This means users can easily start using onchain apps without needing to onramp funds into their wallet.

This also means that apps might not have all the balance information typically available to them by reading onchain data. Smart Wallet indicates that this is the case by responding to [`wallet_getCapabilities` RPC calls](https://eip5792.xyz/reference/getCapabilities) with the `auxiliaryFunds` capability for each chain Smart Wallet users can use their Coinbase balances on.

Expand Down
2 changes: 1 addition & 1 deletion docs/pages/guides/paymasters.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export async function willSponsor({

let callToCheckIndex = 0;
if (calls.length > 1) {
// if there is more than one call, check if the first is a magic spend call
// if there is more than one call, check if the first is a MagicSpend call
if (calls[0].target.toLowerCase() !== magicSpendAddress.toLowerCase())
return false;
callToCheckIndex = 1;
Expand Down
2 changes: 1 addition & 1 deletion docs/pages/why.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Smart Wallet is free for both developers and users.
## Unified Account Across Apps
Smart Wallet users can use the same account and address across all onchain apps.

## Magic Spend
## MagicSpend
Smart Wallet users can connect their coinbase.com account and spend their coinbase.com held ETH from
their Smart Account (Base only, for now).

Expand Down
4 changes: 2 additions & 2 deletions vocs.config.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export default defineConfig({
link: "/guides/paymasters",
},
{
text: "Magic Spend Support",
text: "MagicSpend Support",
link: "/guides/magic-spend",
},
{
Expand Down Expand Up @@ -167,7 +167,7 @@ export default defineConfig({
link: "https://github.com/coinbase/smart-wallet-permissions",
},
{
text: "Magic Spend",
text: "MagicSpend",
link: "https://github.com/coinbase/magic-spend",
},
],
Expand Down

0 comments on commit 710a742

Please sign in to comment.