Added Object Store Support for Crossplane #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need access key and secret access key stored in a secret. Similar to how we handle kubeconfig with clusters. I believe it is supposed to a field https://github.com/crossplane-contrib/provider-civo/blob/main/apis/civo/cluster/v1alpha1/types.go#L50 |
|
@RealHarshThakur so shall I remove the access key from spec struct and just add a var to the secret struct to the spec that contains secret access key and access key ? |
|
We need access key in spec. Yes, add another field called |
satakshigarg
force-pushed
the
ObjectStore_Crossplane_Support
branch
from
95555c4 to
298dee3
Compare
added 2 commits
September 12, 2022 18:40
Signed-off-by: satakshigarg <satakshi@civo.com>
Signed-off-by: satakshigarg <satakshi@civo.com>
satakshigarg
force-pushed
the
ObjectStore_Crossplane_Support
branch
from
298dee3 to
622a241
Compare
RealHarshThakur
requested changes
Sep 12, 2022
added 2 commits
September 12, 2022 22:40
Signed-off-by: satakshigarg <satakshi@civo.com>
Signed-off-by: satakshigarg <satakshi@civo.com>
Sure, I'll update the same |
added 3 commits
September 15, 2022 16:54
Signed-off-by: satakshigarg <satakshi@civo.com>
Signed-off-by: satakshigarg <satakshi@civo.com>
Signed-off-by: satakshigarg <satakshi@civo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the support for Object Store for Crossplane. [Internal/Controllers/objectstore.go is in progress, please ignore]
Signed-off-by: satakshigarg satakshi@civo.com
Description of your changes
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested