Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argparse for config file and version, more config for log customi… #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sabrimjd
Copy link

Hello,
I have been using this script a few time and wanted to contribute.
This is my first time contributing to a project.
Adds:

  • Logging parameters into yaml config
  • Add argument for config file
  • Add argument for version

Let me know about this PR.

@cvk98
Copy link
Owner

cvk98 commented Dec 14, 2023

Hi.
I will definitely try to run the load balancer with your changes and see how it works.
Please explain to me the main meaning of your suggestions.

@Sabrimjd
Copy link
Author

Sabrimjd commented Dec 14, 2023 via email

Copy link

@themoriarti themoriarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants