Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HA group consideration #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pin-chen
Copy link

  • It is possible to be migrated to a machine outside of the HA group and then migrated back due to HA, causing errors.
  • Add an HA group check during migration candidate generation. Nodes not in the same HA group should not be considered.

@kjj2
Copy link

kjj2 commented May 19, 2024

This fails if you have any VMs that aren't assigned to a group in HA. Simple fix:

@@ -255,6 +255,8 @@
         for item in temp:
             if item['type'] != 'service':
                 continue
+            if "group" not in item:
+                continue

             # sid example: vm:134
             vm_id = int(item['sid'].split(':')[1])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants