Add macos testing #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build logic had got a bit confused, so separate out some of the functionality. There is more that could be done, but let's take some improvements. The main aim was to separate out the logic steps needed and make them separate scripts in helpers/, and then to actually call them rather than import them, in setup.py. This is a bit annoying, as it's hard to send around complex state, but the new version should make it a bit clearer what functionality is needed. The aim was to move from setuptools to meson, but I decided that there was enough to clean up to make it worth doing this step first.
The CXC XSPEC conda channel does not currently provide an XSPEC build for macOS ARM, so we have to switch to the CIAO channel.
DougBurke
force-pushed
the
add-macos-testing
branch
from
cf11057 to
c445643
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes some internal re-working of how the module is built, as preparation for switching to
meson-pythonfromsetuptools(mayne).