Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated docs about using ROSE_DATAC #736

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Updated docs about using ROSE_DATAC #736

wants to merge 3 commits into from

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented May 31, 2024 •
edited by MetRonnie
Loading

Companion of cylc/cylc-flow#6117

$CYLC_SHARE_CYCLE_DIR

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.

@wxtim wxtim marked this pull request as draft May 31, 2024 10:11
@wxtim wxtim mentioned this pull request May 31, 2024
Open
8 tasks
@wxtim wxtim self-assigned this May 31, 2024
@wxtim wxtim added the small label May 31, 2024
@wxtim wxtim requested a review from oliver-sanders May 31, 2024 10:12
@wxtim wxtim added this to the 8.3.x milestone May 31, 2024
@wxtim wxtim marked this pull request as ready for review May 31, 2024 10:13
@oliver-sanders oliver-sanders changed the base branch from master to 8.3.x June 27, 2024 15:08
@oliver-sanders oliver-sanders changed the base branch from 8.3.x to master September 17, 2024 12:29
@oliver-sanders oliver-sanders modified the milestones: 8.3.x, 8.4.0 Sep 17, 2024
@oliver-sanders
Copy link
Member

(changed milestone and base branch to match pinned PR)

@oliver-sanders oliver-sanders modified the milestones: 8.4.0, 8.5.0 Dec 3, 2024
@wxtim wxtim requested a review from MetRonnie January 10, 2025 09:50
@wxtim
Updated docs about using ROSE_DATAC
8798b8a 
Update src/reference/job-script-vars/var-list.txt

Update src/workflow-design-guide/general-principles.rst

Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>

Update src/reference/job-script-vars/var-list.txt

Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>

response to review
@wxtim wxtim force-pushed the feature.CYLC_SHARE_CYCLE_DIR branch from 1cf2fe4 to 8798b8a Compare January 10, 2025 10:48
@wxtim wxtim requested a review from MetRonnie January 10, 2025 10:49
@MetRonnie MetRonnie mentioned this pull request Jan 10, 2025
Closed
1 task
wxtim and others added 2 commits January 10, 2025 13:04
@wxtim @MetRonnie
Apply suggestions from code review
1cbeeba 
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
@wxtim @MetRonnie
Update src/workflow-design-guide/general-principles.rst
07c183a 
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
@wxtim wxtim requested a review from MetRonnie January 10, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

@oliver-sanders oliver-sanders Awaiting requested review from oliver-sanders

Assignees

@wxtim wxtim

Labels
small
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wxtim @oliver-sanders @MetRonnie