-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph view: use initialOptions
to save & restore view state on navigation
#1717
Conversation
13e260f
to
4cac41d
Compare
a4dcf25
to
9abf4dc
Compare
5cffe97
to
816110c
Compare
It would be nice to get this in so I can finish off #1763 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm having a bit of a poke about with the Graph view to see if the initial refresh can rely more on Vue's reactivity than manual polling, but this will do for the time being
@oliver-sanders If I make a new issue for Ronnies note above. pick ee02689 Use initialOptions prop to save view state |
added e2e tests updated change log fix broken e2e tests review amends review amends change log review amends tests fix change loggit Do initial refresh safely when autorefresh is off added town crier log reverted CHANGES.md as using towncrier fix empty graph when switching between workflows added e2e test for 'loads graph when switching between workflows'
3c06b60
to
4023d09
Compare
We can also squash-merge PRs (note, you don't need separate commits for changelog, tests, etc, they can go in together with the feature). |
Unfortunately the auto-refresh option appears to be flaky for me. Sometimes the graph comes back, sometimes it does not. I don't think the diff to the refresh method quite did the job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for review...
For testing the autoRefresh setting a console log can be added to the async refresh ()
function and it should show that - when the component mounts and autorefresh is off - the data polling stops when the nodeDimensions has been calculated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
@MetRonnie, please check you're happy with new changes and whack the merge button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it does the job from my testing out
These changes build on the work undertaken to save & restore workspace layout on navigation #1664
Which is part of a larger issue #662
There was an equivalent pull request for the log view #1688
There is an equivalent pull request for the tree view which this builds on: #1705
There is an equivalent pull request for the table view which this builds on: #1711
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present).CHANGES.md
entry included if this is a change that can affect users?.?.x
branch.