Skip to content
This repository has been archived by the owner on Dec 6, 2017. It is now read-only.

Parameterized Test Failure #170 #172

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jrote1
Copy link

@jrote1 jrote1 commented Aug 22, 2014

Review on Reviewable

@jrote1
Copy link
Author

jrote1 commented Aug 22, 2014

@vicb the pull request you requested

@jrote1 jrote1 changed the title Parameterized Test Failure #170 Parameterized Test Failure @#170 Aug 22, 2014
@jrote1 jrote1 changed the title Parameterized Test Failure @#170 Parameterized Test Failure #170 Aug 22, 2014
ParameterizedClass<GenericArgument> _parameterizedClass;

ClassWithParameterizedDependency(this._parameterizedClass);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the style:

  • space before "{"
  • indentation is 2 white spaces

@vicb
Copy link
Contributor

vicb commented Aug 22, 2014

Thanks, that will help to get the problem fixed.
Please fix the code style.
If you haven't already done you need to sign the CLA https://github.com/angular/angular.dart/blob/master/CONTRIBUTING.md#cla

@jrote1
Copy link
Author

jrote1 commented Aug 22, 2014

Sorted all the styling issues.

CLA already signed

@vicb
Copy link
Contributor

vicb commented Aug 22, 2014

Awesome, thanks

@jrote1
Copy link
Author

jrote1 commented Sep 5, 2014

Any progress on this?

@vicb
Copy link
Contributor

vicb commented Sep 5, 2014

I'm afraid there is no way to fix other than #106 but that implies to raise Dart req to 1.7+ (1.7 is not out yet, 1.6 has just been released). I would love to be proved wrong though.

@jrote1
Copy link
Author

jrote1 commented Sep 5, 2014

I have just started looking into it and have noticed that injector.get returns the correct but the test still fails which to me does not make any sense!

@vicb
Copy link
Contributor

vicb commented Sep 5, 2014

Any help is appreciated here. Remember to test both the Dart & JS versions.

@jrote1
Copy link
Author

jrote1 commented Oct 21, 2014

#170 Tag Issue

@rkirov rkirov self-assigned this Jan 21, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants