Add support for IBM Cloud #434
Conversation
TODO: Fix error with the encryptation/TLS certs
Added cpu, mem and timeout variables Deleted TCP connection
Improved job configmap
Added documentation
Optimized code engine job creation
Added IBM Code Engine test
There was a problem hiding this comment.
Thanks for taking the time here!
I don't have an IBM Cloud setup to test this against, but I'm happy to merge it in provided you've verified things work as expected.
As this contribution is a puppy I'd appreciate your commitment to continue maintaining this code and respond to issues and fix bugs in this integration. Are you happy to do that?
| @@ -119,6 +119,18 @@ cloudprovider: | |||
| docker_image: "daskdev/dask:latest" # docker image to use | |||
| bootstrap: true # It is assumed that the OS image does not have Docker and needs bootstrapping. Set this to false if using a custom image with Docker already installed. | |||
|
|
|||
| ibm: | |||
| api_key: null | |||
There was a problem hiding this comment.
Is there not a global location where IBM stores credentials? For example AWS stores things in ~/.aws/credentials and we read it from there.
There was a problem hiding this comment.
No, according to the documentation it is not stored anywhere visible to the user. That is why it is necessary to add the API key manually.
|
I have fixed all the suggestions you have made :) I have tested the Code Engine backend on IBM and everything works fine. Of course! I will be happy to help fix bugs and suggestions that may arise over time in this backend. |
No description provided.