Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix. Add alt text to ggplot's added to a pptx with ph_with.gg. Closes #556. #561

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

trekonom
Copy link
Contributor

This PR fixes a bug in ph_with.gg. It allows to add an alternative text to a ggplot with ph_with.gg again, thereby closing #556.

As a new feature an alt text added via ggplot2::labs is used as alt text by default if any.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.53%. Comparing base (338ea33) to head (226420a).
Report is 1 commits behind head on master.

Files Patch % Lines
R/ppt_ph_with_methods.R 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
+ Coverage   74.09%   83.53%   +9.44%     
==========================================
  Files          40       40              
  Lines        5609     5612       +3     
==========================================
+ Hits         4156     4688     +532     
+ Misses       1453      924     -529     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidgohel davidgohel merged commit 55682a2 into davidgohel:master Mar 16, 2024
5 checks passed
@davidgohel
Copy link
Owner

thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants