Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve plot_layout_properties: correct slide width/height, add title (closes #577) #580

Merged

Conversation

markheckmann
Copy link
Contributor

small visual improvement for plot_layout_properties().

Currently, a box is drawn around the plotted placeholders which does not reflect slide width and height properly, as it depends on device size. With the changes, a box with the proper slide height/width independent of device size is used. plot_layout_properties() also gains a 'title' parameter, which will add the layout name as the plot title. Defaults to FALSE, to not alter the old behavior.

Before

New

`plot_layout_properties()` gains a 'title' parameter, which
will add the layout name as the plot title. Defaults to `FALSE`,
 to not alter the old behavior. Also, the slide width and height
are now correctly displayed in the plot. Before, a box was drawn
around the plot area. However, the plot area varies with device
size, not slide size.
markheckmann added a commit to Majid-Eismann/robocop that referenced this pull request Aug 21, 2024
Add patched version of `officer::plot_layout_properties()`.
There is a [PR pending](davidgohel/officer#580).
This version, however, additionally plots the placeholder's shape id into
its upper right corner.
@davidgohel
Copy link
Owner

@markheckmann sorry for the time it took to merge the PR!

@davidgohel davidgohel merged commit ab4d697 into davidgohel:master Aug 27, 2024
3 checks passed
@markheckmann markheckmann deleted the improve_plot_layout_properties branch August 28, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants