Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make released artifacts smaller #106

Merged
merged 36 commits into from
Nov 7, 2022
Merged

Conversation

bollwyvl
Copy link

@bollwyvl bollwyvl commented Nov 6, 2022

References

Changes

  • cut some more unused js assets
    • 17mb integration.min.js is the big win
    • needs more verification
  • remove duplicated whl assets with techniques from fix: make python package smaller bqplot/bqplot#1228
  • move tests out-of-tree
  • rework coverage
  • look again at separating out the fancy shapes, templates, stencils, etc.

@bollwyvl bollwyvl changed the title Make released assets smaller Make released artifacts smaller Nov 6, 2022
@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.04%. Comparing base (2ad777a) to head (67e0144).

Files with missing lines Patch % Lines
py_packages/ipydrawio/src/ipydrawio/__init__.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #106       +/-   ##
===========================================
- Coverage   97.12%   59.04%   -38.09%     
===========================================
  Files          21       14        -7     
  Lines         730      542      -188     
  Branches       78       76        -2     
===========================================
- Hits          709      320      -389     
- Misses         12      220      +208     
+ Partials        9        2        -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bollwyvl
Copy link
Author

bollwyvl commented Nov 7, 2022

previous

87.6 MB ipydrawio-1.2.1-py3-none-any.whl
41.5 MB ipydrawio-1.2.1.tar.gz

current sizes

   24.9 MiB [##########]  ipydrawio-1.2.2-py3-none-any.whl                                                                  
   22.9 MiB [######### ]  ipydrawio-1.2.2.tar.gz
    6.0 MiB [##        ]  ipydrawio_mathjax-1.2.2-py3-none-any.whl
    5.9 MiB [##        ]  ipydrawio-mathjax-1.2.2.tar.gz
   84.0 KiB [          ]  deathbeds-ipydrawio-1.2.2.tgz
   72.0 KiB [          ]  ipydrawio-export-1.2.2.tar.gz
   68.0 KiB [          ]  ipydrawio_export-1.2.2-py3-none-any.whl
   28.0 KiB [          ]  deathbeds-ipydrawio-jupyter-templates-1.2.2.tgz
   24.0 KiB [          ]  deathbeds-ipydrawio-webpack-20.5.0.tgz
   24.0 KiB [          ]  ipydrawio_widgets-1.2.2-py3-none-any.whl
   20.0 KiB [          ]  ipydrawio-widgets-1.2.2.tar.gz
   16.0 KiB [          ]  deathbeds-ipydrawio-pdf-1.2.2.tgz
   12.0 KiB [          ]  deathbeds-ipydrawio-notebook-1.2.2.tgz
    8.0 KiB [          ]  deathbeds-ipydrawio-mathjax-1.2.2.tgz
    4.0 KiB [          ]  SHA256SUMS

@bollwyvl bollwyvl mentioned this pull request Nov 7, 2022
25 tasks
@bollwyvl bollwyvl marked this pull request as ready for review November 7, 2022 17:20
@bollwyvl bollwyvl merged commit 5442918 into deathbeds:master Nov 7, 2022
@bollwyvl bollwyvl deleted the gh-63-smaller branch November 7, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant