Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not fail-fast for docker publish #2642

Merged
merged 1 commit into from
Dec 18, 2024
Merged

do not fail-fast for docker publish #2642

merged 1 commit into from
Dec 18, 2024

Conversation

siddvenk
Copy link
Contributor

Description

This change migrates the docker build process for all containers to self-hosted runners. We have been seeing issues with github-hosted runners and docker push failures. There is not much to go off of for those failures https://github.com/deepjavalibrary/djl-serving/actions/runs/12393618923/job/34595251621. It just says denied: with no reason/explanation.

For whatever reason, this does not occur on self-hosted runners. So to unblock ourselves for the time being, we'll use those.

Example run with these changes: https://github.com/deepjavalibrary/djl-serving/actions/runs/12400236498

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Have you manually built the docker image and verify the change?
  • Have you run related tests? Check how to set up the test environment here; One example would be pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

@siddvenk siddvenk requested review from zachgk and a team as code owners December 18, 2024 19:59
@siddvenk siddvenk merged commit eaa70af into master Dec 18, 2024
17 checks passed
@siddvenk siddvenk deleted the docker-push branch December 18, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants