Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable nightly publishes per container based on test suite results #2654

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

siddvenk
Copy link
Contributor

@siddvenk siddvenk commented Jan 7, 2025

Description

The current nightly pipeline only publishes updated nightly images if all integration tests pass. This change enables publishing of nightly containers when the relevant tests succeed, rather than requiring all tests across all containers.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Please add the link of Integration Tests Executor run with related tests.
  • Have you manually built the docker image and verify the change?
  • Have you run related tests? Check how to set up the test environment here; One example would be pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

Test Case 1: Forcing all tests to succeed will result in all images being published:

https://github.com/deepjavalibrary/djl-serving/actions/runs/12658537776

Test Case 2: Forcing all tests to fail will result in no images being published:

https://github.com/deepjavalibrary/djl-serving/actions/runs/12657937515/job/35275584322

Test Case 3: Randomly fail/succeed tests to get partial set of images being published:

https://github.com/deepjavalibrary/djl-serving/actions/runs/12659768125

Test Case 4: A real run with actual tests.

https://github.com/deepjavalibrary/djl-serving/actions/runs/12660372918

@siddvenk siddvenk force-pushed the nightly-pipeline branch 2 times, most recently from 835f091 to d838d98 Compare January 7, 2025 21:38
@siddvenk siddvenk marked this pull request as ready for review January 7, 2025 22:29
@siddvenk siddvenk requested review from zachgk and a team as code owners January 7, 2025 22:29
@siddvenk siddvenk merged commit 9e8e232 into master Jan 7, 2025
46 checks passed
@siddvenk siddvenk deleted the nightly-pipeline branch January 7, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants