Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workflow] Use self-host instance for trtllm image sync #2660

Merged
merged 8 commits into from
Jan 14, 2025
Merged

Conversation

HappyAmazonian
Copy link
Contributor

@HappyAmazonian HappyAmazonian commented Jan 14, 2025

Description

Currently, we use ubuntu-latest to upload images. It gets out of storage since the trtllm image is too big
This PR change is to use self-host instance for trtllm image sync.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Please add the link of Integration Tests Executor run with related tests.
  • Have you manually built the docker image and verify the change?
  • Have you run related tests? Check how to set up the test environment here; One example would be pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Feature/Issue validation/testing

I commented out the uploading code and verified that trtllm sync is using aarch instance
https://github.com/deepjavalibrary/djl-serving/actions/runs/12759641850/job/35563767282

@HappyAmazonian HappyAmazonian requested review from zachgk and a team as code owners January 14, 2025 02:11
@HappyAmazonian HappyAmazonian changed the title [workflow]Use self-host instance for trtllm image sync [workflow] Use self-host instance for trtllm image sync Jan 14, 2025
@siddvenk siddvenk merged commit 2ae0aab into master Jan 14, 2025
8 checks passed
@siddvenk siddvenk deleted the instance_size branch January 14, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants