-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for concurrency
option when running locally
#107
Conversation
|
@@ -139,6 +107,8 @@ export type Concurrency = Range<0, 51>; | |||
export type NextRouteString = `/api/${string}`; | |||
|
|||
export interface Manifest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Manifest
type must not be extended for local-only features. I suggest creating a new type that extends this one.
}; | ||
const fns: Record<string, FunctionConfiguration<any>> = {}; | ||
|
||
export function setupFn<F extends DeferableFunction>(metadata: Manifest) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps 'registerFunction' would be a more suitable name in this case.
@daguej thank you for submitting the issue and pull request. Your work is great! I just have a couple of comments. |
@gearnode FYI I will not have any additional time to dedicate to working on this. I encourage your team to take this branch and get it over the finish line. |
Fixes #106 by adding an in-memory queue for function invocations.