chore(storybook): Added publishing of PR storybook to S3 bucket #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majames
force-pushed
the
chore/publish-storybook-on-pr
branch
2 times, most recently
from
211b716 to
8864428
Compare
|
😞 turns out Travis doesn't allow you to deploy on PR: travis-ci/travis-ci#7338 (comment) Will have to look at using the |
majames
force-pushed
the
chore/publish-storybook-on-pr
branch
3 times, most recently
from
fde5fa5 to
87e69e0
Compare
majames
force-pushed
the
chore/publish-storybook-on-pr
branch
from
87e69e0 to
999b0bd
Compare
|
Alright moved deploy config from travis-ci yaml config to a build script so it's working now 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 (allthereviews)
Need to release PR to check this is working. @zzarcon does devlucky have a slack channel? If so, would be good to publish a link to s3 bucket PRs to slack channel in the future 😄