feat(packages): util에 fetcher 추가 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sukvvon
reviewed
Feb 12, 2024
sukvvon
reviewed
Feb 12, 2024
sukvvon
reviewed
Feb 12, 2024
|
vercel에 환경 변수 추가했습니다! 👌 |
sukvvon
reviewed
Feb 12, 2024
sukvvon
reviewed
Feb 12, 2024
packages/shared/utils/src/request.ts
Outdated
| import axios from 'axios'; | ||
|
|
||
| const axiosInstance = axios.create({ | ||
| baseURL: `${process.env.HOST}`, |
There was a problem hiding this comment.
VITE_API_HOST로 바꿔야 작동할 것 같습니다! 🤔
There was a problem hiding this comment.
util에서 vite환경변수 접근이 불가능해서 web에서 base_url 설정하도록 바꿧습니다.
sukvvon
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 번호
작업한 목록을 작성해 주세요
스크린샷
pr 포인트나 궁금한 점을 작성해 주세요