Bug/#8011 ordering with arithmetic expression

[sgehrig]

This is the PR requested for issue #8011.

It includes tests for some arithmetic expressions being used in ORDER BY clauses of a DQL query.

• ORDER BY p.id + p.id ASC ✅
• ORDER BY 1 + p.id ASC 🚫
• ORDER BY p.id + 1 ASC ✅
• ORDER BY s + 1 DESC 🚫 (where s is a ResultVariable)
• ORDER BY 1 + s DESC 🚫 (where s is a ResultVariable)
• ORDER BY s + p.id DESC 🚫 (where s is a ResultVariable)
• ORDER BY p.id + s DESC ✅ (where s is a ResultVariable)

[sgehrig]

Strangely the pgsql test fail for the test cases added because Postgres does not support using column aliases in expressions used in ORDER BY items.

Is this something Doctrine ORM has ever even tackled?

[sgehrig]

See #8011 (comment) for some more discoveries.

[github-actions]

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

[sgehrig]

Still considered valid I assume. I'm not sure about the fix however, so somebody needs to look into that please.

[SenseException]

@greg0ire Should this target 2.21.x or 3.4.x?

[greg0ire]

2.20 since it's a bugfix

[SenseException]

@sgehrig Please rebase your branch to 2.20.x and resolve conflicts in Parser.php.

[sgehrig]

@SenseException Done. Thanks for looking into my PR.

[sgehrig]

Strangely the pgsql test fail for the test cases added because Postgres does not support using column aliases in expressions used in ORDER BY items.

Is this something Doctrine ORM has ever even tackled?

Coming back to this one as this makes the tests fail. I'm not entirely sure, but I assume the issue is that e.g. \Doctrine\Tests\ORM\Functional\GH8011Test::testOrderWithArithmeticExpressionWithResultVariableAndLiteral uses the query

SELECT p,  p.salary AS HIDDEN s FROM Doctrine\Tests\Models\Company\CompanyEmployee p ORDER BY s + 1 DESC

that references p.salary as HIDDEN s and uses s in the ORDER BY. However I do not understand why MariaDB, MySQL or SQLite do work. From my understanding HIDDEN is a keyword that does not affect the SQL query generation but rather hydration.

Even the documentation lists a similar example:

$query = $em->createQuery('SELECT u, u.posts_count + u.likes_count AS HIDDEN score FROM CmsUser u ORDER BY score');
$users = $query->getResult(); // array of User objects

I could not find a test case that handles this scenario however.